Remove file mutex usage - #43
Conversation
📝 WalkthroughWalkthroughDiceware now reads its wordlist without filesystem mutex operations. Epub Reader removes filesystem mutex handling from background text-file reads and EPUB parsing. Todo List removes mutex handling from save and load operations. The Diceware, Epub Reader, and Todo List manifest versions are incremented to 0.13.0, 0.10.0, and 0.12.0. Merge Risk: ⚪ Minimal · up to This PR removes obsolete filesystem-mutex usage from a few app paths and updates one app version. A localized comment still references the removed lock, but no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (3 skipped: 3 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Apps/EpubReader/main/Source/EpubReaderAsync.cpp (1)
114-116: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUpdate comments that still describe the removed filesystem mutex.
asyncOpenCompletestill says that text was read “under the FS lock” and that empty content can indicate a “lock timeout”. This path no longer uses the mutex. Update those comments to describe only read errors.Proposed comment update
- // Content was pre-read in backgroundOpenTask (under the FS lock) - + // Content was pre-read in backgroundOpenTask - // no SD I/O needed here on the LVGL task. - // Text content empty (lock timeout or read error) - show error in browser + // Text content empty (read error) - show error in browser
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d25e101f-c568-4ad6-a4fa-6841e17f2386
📒 Files selected for processing (6)
Apps/Diceware/main/Source/Diceware.cppApps/Diceware/manifest.propertiesApps/EpubReader/main/Source/EpubReaderAsync.cppApps/EpubReader/manifest.propertiesApps/TodoList/main/Source/TodoList.cppApps/TodoList/manifest.properties
💤 Files with no reviewable changes (2)
- Apps/TodoList/main/Source/TodoList.cpp
- Apps/Diceware/main/Source/Diceware.cpp
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
The API is removed from the upcoming SDK.
Summary by CodeRabbit