App updates for SDK changes - #45
Conversation
- tactility.py v5.0.0 - fixes for app launching & result - posix support - other fixes
|
Warning Review limit reachedNext included review available in 3 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe applications migrated from ESP-IDF component registration to Tactility SDK project and component macros. SDK paths are now mandatory and normalized to absolute paths. The build tool gained versioned CMake generation, POSIX CMake/Ninja builds, shared-library artifact handling, and manifest-based package naming. ESP-NOW Bridge now uses stream-based file selection and widget teardown handling. Media Keys updated HID acquisition and cleanup. Application versions were incremented, and HelloWorld added POSIX support. Merge Risk: 🟡 Moderate · up to This PR updates SDK/build integration and adds file-picker and Bluetooth HID lifecycle changes. Several app builds can fail under relative SDK paths, Breakout may miss a required audio component, and teardown races could cause leaked or invalid device state; these concrete risks should be resolved or explicitly accepted before merging. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Title checkExplanation The title accurately describes the broad application updates for the Tactility SDK migration. It is concise and related to the main changes, including build-system updates, POSIX support, and app fixes. Full details: Docstring CoverageExplanation Docstring coverage is 6.25% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 32 functions across 5 files. (54 skipped: 54 unsupported.) ✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 5
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Team
Run ID: 11defce0-afb1-4331-8906-9f157b1c8b0f
📒 Files selected for processing (59)
Apps/Brainfuck/CMakeLists.txtApps/Brainfuck/main/CMakeLists.txtApps/Brainfuck/manifest.propertiesApps/Breakout/CMakeLists.txtApps/Breakout/main/CMakeLists.txtApps/Breakout/manifest.propertiesApps/Calculator/CMakeLists.txtApps/Calculator/main/CMakeLists.txtApps/Calculator/manifest.propertiesApps/Diceware/CMakeLists.txtApps/Diceware/main/CMakeLists.txtApps/Diceware/manifest.propertiesApps/EpubReader/CMakeLists.txtApps/EpubReader/main/CMakeLists.txtApps/EpubReader/manifest.propertiesApps/EspNowBridge/CMakeLists.txtApps/EspNowBridge/main/CMakeLists.txtApps/EspNowBridge/main/Source/EspNowBridge.cppApps/EspNowBridge/main/Source/EspNowBridge.hApps/EspNowBridge/main/Source/main.cppApps/EspNowBridge/manifest.propertiesApps/GPIO/CMakeLists.txtApps/GPIO/main/CMakeLists.txtApps/GPIO/manifest.propertiesApps/GraphicsDemo/CMakeLists.txtApps/GraphicsDemo/main/CMakeLists.txtApps/GraphicsDemo/manifest.propertiesApps/HelloWorld/CMakeLists.txtApps/HelloWorld/main/CMakeLists.txtApps/HelloWorld/manifest.propertiesApps/M5UnitTest/CMakeLists.txtApps/M5UnitTest/main/CMakeLists.txtApps/M5UnitTest/manifest.propertiesApps/Magic8Ball/CMakeLists.txtApps/Magic8Ball/main/CMakeLists.txtApps/Magic8Ball/manifest.propertiesApps/MediaKeys/CMakeLists.txtApps/MediaKeys/main/CMakeLists.txtApps/MediaKeys/main/Source/MediaKeys.cppApps/MediaKeys/manifest.propertiesApps/MystifyDemo/CMakeLists.txtApps/MystifyDemo/main/CMakeLists.txtApps/MystifyDemo/manifest.propertiesApps/SerialConsole/CMakeLists.txtApps/SerialConsole/main/CMakeLists.txtApps/SerialConsole/manifest.propertiesApps/Snake/CMakeLists.txtApps/Snake/main/CMakeLists.txtApps/Snake/manifest.propertiesApps/TamaTac/CMakeLists.txtApps/TamaTac/main/CMakeLists.txtApps/TamaTac/manifest.propertiesApps/TodoList/CMakeLists.txtApps/TodoList/main/CMakeLists.txtApps/TodoList/manifest.propertiesApps/TwoEleven/CMakeLists.txtApps/TwoEleven/main/CMakeLists.txtApps/TwoEleven/manifest.propertiestactility.py
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
Summary by CodeRabbit
New Features
posix-x86_64platform.Improvements
Chores