Skip to content

App updates for SDK changes - #45

Merged
KenVanHoeylandt merged 6 commits into
mainfrom
develop
Aug 31, 2026
Merged

App updates for SDK changes#45
KenVanHoeylandt merged 6 commits into
mainfrom
develop

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Aug 31, 2026

Copy link
Copy Markdown
Contributor
  • tactility.py v5.0.0
  • fixes for app launching & result
  • posix support
  • other fixes

Summary by CodeRabbit

  • New Features

    • Added POSIX platform build and packaging support, including shared-library artifacts.
    • Added automatic generation and updating of app build configuration.
    • ESP-NOW Bridge now uses the built-in file picker for selecting update files.
    • HelloWorld now supports the posix-x86_64 platform.
  • Improvements

    • Standardized app builds on the Tactility SDK workflow.
    • Updated package naming and installation to use each app’s manifest identity.
  • Chores

    • Incremented versions for the updated applications.

- tactility.py v5.0.0
- fixes for app launching & result
- posix support
- other fixes
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 3 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: d613e780-26b0-4e9e-9cb7-737f15769ac2

📥 Commits

Reviewing files that changed from the base of the PR and between 817bffa and 3e94b35.

📒 Files selected for processing (5)
  • .github/actions/build-app/action.yml
  • Apps/Breakout/main/CMakeLists.txt
  • Apps/M5UnitTest/main/CMakeLists.txt
  • Apps/MediaKeys/main/Source/MediaKeys.cpp
  • tactility.py
📝 Walkthrough

Walkthrough

The applications migrated from ESP-IDF component registration to Tactility SDK project and component macros. SDK paths are now mandatory and normalized to absolute paths. The build tool gained versioned CMake generation, POSIX CMake/Ninja builds, shared-library artifact handling, and manifest-based package naming. ESP-NOW Bridge now uses stream-based file selection and widget teardown handling. Media Keys updated HID acquisition and cleanup. Application versions were incremented, and HelloWorld added POSIX support.

Merge Risk: 🟡 Moderate · up to 817bf

This PR updates SDK/build integration and adds file-picker and Bluetooth HID lifecycle changes. Several app builds can fail under relative SDK paths, Breakout may miss a required audio component, and teardown races could cause leaked or invalid device state; these concrete risks should be resolved or explicitly accepted before merging.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 6.25% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 32 functions across 5 files. (54 skipped: … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the broad application updates for the Tactility SDK migration. It is concise and related to the main changes, including build-system updates, POSIX support, and app fixe…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title accurately describes the broad application updates for the Tactility SDK migration. It is concise and related to the main changes, including build-system updates, POSIX support, and app fixes.

Full details: Docstring Coverage

Explanation

Docstring coverage is 6.25% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 32 functions across 5 files. (54 skipped: 54 unsupported.)

✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 11defce0-afb1-4331-8906-9f157b1c8b0f

📥 Commits

Reviewing files that changed from the base of the PR and between 2ca256e and 817bffa.

📒 Files selected for processing (59)
  • Apps/Brainfuck/CMakeLists.txt
  • Apps/Brainfuck/main/CMakeLists.txt
  • Apps/Brainfuck/manifest.properties
  • Apps/Breakout/CMakeLists.txt
  • Apps/Breakout/main/CMakeLists.txt
  • Apps/Breakout/manifest.properties
  • Apps/Calculator/CMakeLists.txt
  • Apps/Calculator/main/CMakeLists.txt
  • Apps/Calculator/manifest.properties
  • Apps/Diceware/CMakeLists.txt
  • Apps/Diceware/main/CMakeLists.txt
  • Apps/Diceware/manifest.properties
  • Apps/EpubReader/CMakeLists.txt
  • Apps/EpubReader/main/CMakeLists.txt
  • Apps/EpubReader/manifest.properties
  • Apps/EspNowBridge/CMakeLists.txt
  • Apps/EspNowBridge/main/CMakeLists.txt
  • Apps/EspNowBridge/main/Source/EspNowBridge.cpp
  • Apps/EspNowBridge/main/Source/EspNowBridge.h
  • Apps/EspNowBridge/main/Source/main.cpp
  • Apps/EspNowBridge/manifest.properties
  • Apps/GPIO/CMakeLists.txt
  • Apps/GPIO/main/CMakeLists.txt
  • Apps/GPIO/manifest.properties
  • Apps/GraphicsDemo/CMakeLists.txt
  • Apps/GraphicsDemo/main/CMakeLists.txt
  • Apps/GraphicsDemo/manifest.properties
  • Apps/HelloWorld/CMakeLists.txt
  • Apps/HelloWorld/main/CMakeLists.txt
  • Apps/HelloWorld/manifest.properties
  • Apps/M5UnitTest/CMakeLists.txt
  • Apps/M5UnitTest/main/CMakeLists.txt
  • Apps/M5UnitTest/manifest.properties
  • Apps/Magic8Ball/CMakeLists.txt
  • Apps/Magic8Ball/main/CMakeLists.txt
  • Apps/Magic8Ball/manifest.properties
  • Apps/MediaKeys/CMakeLists.txt
  • Apps/MediaKeys/main/CMakeLists.txt
  • Apps/MediaKeys/main/Source/MediaKeys.cpp
  • Apps/MediaKeys/manifest.properties
  • Apps/MystifyDemo/CMakeLists.txt
  • Apps/MystifyDemo/main/CMakeLists.txt
  • Apps/MystifyDemo/manifest.properties
  • Apps/SerialConsole/CMakeLists.txt
  • Apps/SerialConsole/main/CMakeLists.txt
  • Apps/SerialConsole/manifest.properties
  • Apps/Snake/CMakeLists.txt
  • Apps/Snake/main/CMakeLists.txt
  • Apps/Snake/manifest.properties
  • Apps/TamaTac/CMakeLists.txt
  • Apps/TamaTac/main/CMakeLists.txt
  • Apps/TamaTac/manifest.properties
  • Apps/TodoList/CMakeLists.txt
  • Apps/TodoList/main/CMakeLists.txt
  • Apps/TodoList/manifest.properties
  • Apps/TwoEleven/CMakeLists.txt
  • Apps/TwoEleven/main/CMakeLists.txt
  • Apps/TwoEleven/manifest.properties
  • tactility.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread Apps/Breakout/main/CMakeLists.txt Outdated
Comment thread Apps/Calculator/CMakeLists.txt
Comment thread Apps/MediaKeys/main/CMakeLists.txt
Comment thread Apps/MediaKeys/main/Source/MediaKeys.cpp
Comment thread Apps/MediaKeys/main/Source/MediaKeys.cpp
@KenVanHoeylandt
KenVanHoeylandt merged commit b6ae9b8 into main Aug 31, 2026
21 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the develop branch August 31, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant