Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-forms-ignore-stale.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tanstack/form-core": patch
---

Ignore aborted async form-level validation results so a slower previous run cannot overwrite newer form state.
1 change: 1 addition & 0 deletions packages/form-core/src/FormApi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2232,6 +2232,7 @@ export class FormApi<
} catch (e: unknown) {
rawError = e as ValidationError
}
if (controller.signal.aborted) return resolve(undefined)
const { formError, fieldErrors: fieldErrorsFromNormalizeError } =
normalizeError<TFormData>(rawError)

Expand Down
41 changes: 41 additions & 0 deletions packages/form-core/tests/FormApi.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1420,6 +1420,47 @@ describe('form api', () => {
})
})

it('should ignore aborted async form-level validation results', async () => {
vi.useFakeTimers()

try {
const form = new FormApi({
defaultValues: {
name: 'valid',
},
validators: {
onChangeAsyncDebounceMs: 0,
onChangeAsync: async ({ value }) => {
if (value.name === 'slow-invalid') {
await sleep(2000)
return 'Stale validation result'
}
await sleep(50)
return undefined
},
},
})
const field = new FieldApi({
form,
name: 'name',
})
form.mount()
field.mount()

field.setValue('slow-invalid')
await vi.advanceTimersByTimeAsync(0)
field.setValue('valid')
await vi.advanceTimersByTimeAsync(50)
expect(form.state.errors).toEqual([])

await vi.advanceTimersByTimeAsync(2000)
expect(form.state.errors).toEqual([])
expect(form.state.errorMap.onChange).toBeUndefined()
} finally {
vi.useRealTimers()
}
})

it('should run validation onBlur', () => {
const form = new FormApi({
defaultValues: {
Expand Down