Repository navigation
Retry a D1 overload once before failing that provider - #636
Merged
Conversation
A spent D1 window waits D1_WINDOW_WAIT_MS and runs the provider once more, in the models poll and the spec-sync shard. A second overload still records ingest_failed. Spec sync writes degraded only after that second failure, and only after the wait, so a recovered retry stays active.
|
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
tombeckenham
deleted the
635-models-poll-a-provider-that-hits-d1-overload-is-failed-and-marked-degraded-instead-of-retried-after-the-wait
branch
November 10, 2026 07:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
d1WindowExhausted) waitsD1_WINDOW_WAIT_MSand retries that provider once. A second overload still recordsingest_failed. A recovered retry records none, and the poll still does not writeproviders.status.degradedis written only when the retry also fails, and only after the wait, so the status write is not inside the spent window. The 05:11 pair (worldlabs, zai-coding-plan) came from this shard.Fixes #635
Test plan
ingest_failed, status staysactiveingest_failed, no third attemptactivedegradedonly after a second overload, and the next provider runs after that wait