Skip to content

Drop FAL endpoints the models API no longer serves - #644

Merged
tombeckenham merged 1 commit into
mainfrom
641-fal-models-poll-404s-every-run-since-2026-11-12-2146-removed-endpoint-in-endpoint_id-filter
Nov 12, 2026
Merged

tombeckenham merged 1 commit into
mainfrom
641-fal-models-poll-404s-every-run-since-2026-11-12-2146-removed-endpoint-in-endpoint_id-filter

Conversation

@tombeckenham

Copy link
Copy Markdown
Collaborator

Fixes #641

The active FAL search still lists fal-ai/video-prompt-generator (category: llm, status: active). GET /v1/models?endpoint_id=fal-ai/video-prompt-generator returns 404 {"error":{"type":"not_found","message":"Endpoint(s) not found"}}, and any endpoint_id filter that includes that id 404s the whole chat-spec batch. That was the fal models fetch failed: 404 Not Found on every models poll since 2026-11-12 21:46 UTC. The same run also logged fal fal-ai/video-prompt-generator llms.txt: 404.

A filtered 404 with that body is now split until the missing id is alone. The poll logs the id and the single-id URL, omits the row, and the usual "no longer listed" path deprecates it. A 404 with any other body still fails the poll. An unfiltered listing 404 still fails the poll.

bun run test src/server/providers/fal-chat-facts.test.ts src/server/providers/fal.test.ts

The active search still lists fal-ai/video-prompt-generator, but any endpoint_id filter that includes it returns 404 Endpoint(s) not found and failed every models poll. Split that batch, omit only the missing id so the poll deprecates the row, and keep every other 404 as a failure.
@changeset-bot

changeset-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2c8c16c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 55 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ee02870e-173a-414d-b859-6d138c9ef712
Commits

Reviewing files that changed from the base of the PR and between 20d83eb and 2c8c16c.

Files selected for processing: 3

  • src/server/providers/fal-chat-facts.test.ts
  • src/server/providers/fal.test.ts
  • src/server/providers/fal.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@tombeckenham
tombeckenham merged commit a225eec into main Nov 12, 2026
5 checks passed
@tombeckenham
tombeckenham deleted the 641-fal-models-poll-404s-every-run-since-2026-11-12-2146-removed-endpoint-in-endpoint_id-filter branch November 12, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FAL models poll 404s every run since 2026-11-12 21:46 (removed endpoint in endpoint_id filter?)

1 participant