Repository navigation
feat: 홈 컬렉션 섹션 및 전체 컬렉션뷰 구현 #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sadturtleman
wants to merge
7
commits into
develop
Choose a base branch
from
feat/977
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
55b9973
feat: 공개 컬렉션 목록 조회 API 연동 및 커서 페이징 공용화
Sadturtleman ad191b1
test: 공개 컬렉션 응답 변환 및 커서 페이징 단위 테스트 추가
Sadturtleman 1f5562e
feat: 공개 컬렉션 카드 추가 및 컬렉션 카드 공통 영역 분리
Sadturtleman f924710
feat: 전체 컬렉션뷰 구현
Sadturtleman 7a471dd
feat: 홈 컬렉션 섹션 구현
Sadturtleman d77a73c
fix: 홈 컬렉션 섹션 위치 및 카드 간격 디자인 QA 반영
Sadturtleman 7bc0acd
feat: 홈 GNB 마이페이지 툴팁 추가
Sadturtleman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
core/resource/src/main/res/drawable/bg_main_my_page_tooltip.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:width="194dp" | ||
| android:height="44dp" | ||
| android:viewportWidth="194" | ||
| android:viewportHeight="44"> | ||
| <!-- 꼬리가 오른쪽 아래(우측에서 35.5dp)에서 마이페이지 탭을 가리킨다. --> | ||
| <group | ||
| android:pivotX="97" | ||
| android:pivotY="22" | ||
| android:rotation="180"> | ||
| <path | ||
| android:fillColor="#6A5DFD" | ||
| android:pathData="M34.0957,0.5C34.7108,-0.1666 36.2483,-0.1667 36.8633,0.5L41.9375,6H180C187.732,6 194,12.268 194,20V30C194,37.7319 187.732,44 180,44H14C6.268,44 0,37.7319 0,30V20C0,12.268 6.268,6 14,6H29.0215L34.0957,0.5Z" /> | ||
| </group> | ||
| </vector> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: Team-WSS/WSS-Android
Length of output: 28431
🏁 Script executed:
Repository: Team-WSS/WSS-Android
Length of output: 7486
🏁 Script executed:
Repository: Team-WSS/WSS-Android
Length of output: 8166
로그인 상태가
true일 때만 툴팁을 표시하세요.MainActivity.getIntent(context)는 로그인 정보를 전달하지 않습니다. 이 경로에서isLogin.value는null일 수 있습니다. 툴팁 상태는 별도로 비동기 갱신되므로, 로그인 상태가 확정되기 전에 홈에서 툴팁 조건을 통과할 수 있습니다.🐛 수정 제안
📝 Committable suggestion
🤖 Prompt for AI Agents