Repository navigation
Conversation
빈 집계 결과의 조기 반환과 인기작 교체를 단위 테스트 및 H2 DB 통합 테스트로 검증한다. Refs #643
5 tasks
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Key Changes
최근 7일간의 집계 후보가 없으면 기존 인기작까지 삭제되던 문제를 수정했습니다.
topNovelIds가 비어 있으면 조기 반환하여 마지막 인기작을 유지합니다. 후보가 있으면 새 인기작을 저장한 뒤 기존 행을 삭제합니다.PopularNovelSchedulerTest: 단위 테스트 6건을 추가했습니다. 기존 인기작 유무에 따른 조기 반환, 새 데이터 저장 후 기존 데이터 삭제 순서, 후보 조회·저장 실패 시 삭제 방지를 검증합니다.PopularNovelSchedulerIntegrationTest: DB 통합 테스트 7건을 추가했습니다. 임시 인기작·사용자·작품·서재 데이터를 넣고 실제 JPA/QueryDSL 경로로 스케줄러를 실행한 뒤, flush·clear 후 DB를 재조회하여 결과를 검증합니다.To Reviewers
빈 후보 여부는 최근 7일간의 집계 쿼리 결과를 기준으로 판단합니다. 후보가 없으면 기존 인기작 전체를 유지하고, 한 건 이상이면 새 집계 결과로 교체합니다.
References
src/test/java/org/websoso/WSSServer/application/PopularNovelSchedulerTest.javasrc/test/java/org/websoso/WSSServer/application/PopularNovelSchedulerIntegrationTest.javasrc/test/resources/application-popular-novel-test.properties