Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
One behaviour. Describe the outcome, not the diff.
Fail closed?
The rule is that uncertainty produces a denial. If this change makes the service
answer
allowed: truesomewhere it used to refuse, that needs to be argued in anissue before a pull request.
DenialReasonmember, a comment saying when it fires, and a test that asserts the reasonDoes it move the wire format?
Check every box that applies, and link the matching change in the other repository:
Decision/DecisionRequestin keygate-clientcanonicalDecisionuntouched → if it moved, keygate-client/src/decision.ts andtest/golden.test.tschanged with it, in the same releaseConfigSchemaentry and an.env.examplelineTests
now)corepack pnpm checkruns lint, format, typecheck and the suite — the same thingsCI does, plus the boot smoke test that asserts
/readyzis503and a decision isa denial while the mirror is unsynced.
Notes for the reviewer
Anything the diff does not show: a design you chose over the alternative that
looks simpler, a case you deliberately did not handle.