Repository navigation
fix(dashboard): handle disabled media model fields - #2199
Closed
changjing9527 wants to merge 1 commit into
Closed
changjing9527 wants to merge 1 commit into
changjing9527 wants to merge 1 commit into
Conversation
Collaborator
|
Closing as superseded by #2105 (same issue #2100). Why keep #2105 instead:
Please continue on #2105. Thanks for the report and the initial fix attempt! |
4 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2100.
When either image or video generation is disabled in the provider modal, its model field is conditionally unmounted.
providerFromForm()still called.trim()unconditionally, soundefined.trim()threw and the catch block silently returnednull. Saving, credential verification, and model tests therefore appeared to do nothing.This change:
Validation
vitest run src/pages/Settings/MediaGeneration/index.test.ts— 2 passedtsc -bwas attempted; the repository currently lacks existing dependencies (dayjs,unified,pdfjs-dist,@ant-design/icons), so the full project check remains environment-blocked.