Fix public Codex skill interface packaging - #73
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThe PR updates the plugin to version 0.3.10, builds a public skills-only package without legacy metadata, adds OpenAI interface settings, and validates the transformed skill, manifest, interface, and ZIP contents. ChangesPublic skills-only packaging
Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant SourceSkills
participant build_codex_skills_only
participant PublicProfile
participant validate_codex_skills_only
SourceSkills->>build_codex_skills_only: Read source SKILL.md
build_codex_skills_only->>PublicProfile: Apply public front matter and interface files
PublicProfile->>validate_codex_skills_only: Provide generated ZIP contents
validate_codex_skills_only->>validate_codex_skills_only: Validate metadata, interface, body, and manifest
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoFix public Codex skill interface packaging
AI Description
Diagram
High-Level Assessment
Files changed (8)
|
Code Review by Qodo
1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| { | ||
| "name": "tree-ring-memory", | ||
| "version": "0.3.9", | ||
| "version": "0.3.10", |
There was a problem hiding this comment.
2. Public plugin repo stays broken 🔗 Cross-repo conflict ≡ Correctness
plugin.json advances the bundled Codex package to 0.3.10 and the release instructions identify its skills-only ZIP as the corrected public artifact, but the separately published tree-ring-memory-codex-plugin repository remains at 0.3.9. Anyone building or submitting from that wrapper still gets a ZIP that copies SKILL.md verbatim with metadata, omits agents/openai.yaml, and retains the over-limit listing subtitle, so the fix does not reach that distribution channel.
Agent Prompt
## Issue description
The standalone `tree-ring-memory-codex-plugin` repository still publishes version 0.3.9 using the obsolete public ZIP builder, despite Tree_Ring_Memory declaring the corrected package as 0.3.10.
## Fix Focus Areas
- plugins/tree-ring-memory/.codex-plugin/plugin.json[1-4]
- plugins/tree-ring-memory/packaging/build-codex-skills-only.py[61-71]
- /cross_repos/tree-ring-memory-codex-plugin/.codex-plugin/plugin.json[1-4]
- /cross_repos/tree-ring-memory-codex-plugin/packaging/build-codex-skills-only.py[26-39]
## Recommended Fix
Coordinate a 0.3.10 update in `tree-ring-memory-codex-plugin`: port the public front-matter renderer, add `skills/tree-ring-memory/agents/openai.yaml`, shorten the public manifest subtitle, update validation and documentation, and publish both repositories or their release artifacts together.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public skills-only ZIP copied legacy
SKILL.mdmetadata that OpenAI ignores and omitted the skill interface file. Codex plugin 0.3.10 now renders public front matter without that metadata, adds supportedagents/openai.yamlinterface fields, and uses a directory subtitle within the 30-character submission limit. The complete skill body and native lifecycle hooks remain unchanged.The public and native profiles remain separate; no Rust runtime or Claude/Agent Zero release changes are required. Documentation identifies the exact public-upload artifact and correctly describes
skill_metadata_ignoredas a warning.Validation: repository plugin-package checks pass, including deterministic ZIPs, unchanged executable hooks, public interface schema and body preservation, and negative metadata/interface cases. OpenAI skill-creator validation passes for the unpacked public skill. Public portal acceptance remains a separate verification step.
High-level PR Summary
This PR fixes the public Codex skills-only ZIP packaging to properly support OpenAI's plugin submission requirements. The build script now strips legacy
metadatafrom skill front matter (which OpenAI ignores), adds a newagents/openai.yamlinterface file with supported fields, and updates the directoryshortDescriptionto fit the 30-character submission limit. The skill body and native lifecycle hooks remain unchanged. The plugin version is bumped from 0.3.9 to 0.3.10. Comprehensive validation checks are added to ensure public interface schema compliance, metadata filtering correctness, skill body preservation, and descriptor length limits.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
plugins/tree-ring-memory/.codex-plugin/plugin.jsonplugins/tree-ring-memory/packaging/codex-skills-only/.codex-plugin/plugin.jsonplugins/tree-ring-memory/packaging/codex-skills-only/skills/tree-ring-memory/agents/openai.yamlplugins/tree-ring-memory/packaging/build-codex-skills-only.pyscripts/validate-plugin-packages.pyplugins/tree-ring-memory/README.mdplugins/AGENTS.mdscripts/AGENTS.mdSummary by CodeRabbit