Skip to content

buf: remove temporary common_api.proto breaking ignore - #70

Merged
Bre77 merged 1 commit into
mainfrom
fm/tp-remove-common-api-breaking-ignore
Oct 12, 2026
Merged

Bre77 merged 1 commit into
mainfrom
fm/tp-remove-common-api-breaking-ignore

Conversation

@Bre77

@Bre77 Bre77 commented Oct 12, 2026

Copy link
Copy Markdown
Member

Deletes the temporary ignore_only block added in #68 now that 4.0.0 is released. buf breaking passes against the @teslemetry/tesla-protocol@4.0.0 tag and main. Config only: no proto changes, no release.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Teslemetry/coderabbit/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9cd97fe6-457a-4477-a0b6-fbde57870329

📥 Commits

Reviewing files that changed from the base of the PR and between 23ea633 and b2feb63.


📒 Files selected for processing (1)
  • buf.yaml

💤 Files with no reviewable changes (1)
  • buf.yaml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.



📝 Walkthrough

Walkthrough

The buf.yaml configuration no longer excludes common_api.proto from four breaking rules.

Changes

Buf breaking-rule configuration

Layer / File(s) Summary
Remove file-specific exceptions
buf.yaml
Removed the breaking.ignore_only exceptions for common_api.proto under four breaking rules.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other


Merge Risk: ⚪ Minimal · up to b2feb

No actionable merge risk is identified from the supplied configuration change; merge after normal checks.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check Passed The description clearly explains the removal of the temporary ignore_only block and identifies the configuration-only scope.
Title check Passed The title clearly and concisely identifies the removal of the temporary common_api.proto breaking-change ignore.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@Bre77
Bre77 merged commit 383c63b into main Oct 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant