Repository navigation
Conversation
The docker-publish workflow switched from the workflow_run trigger to a direct dispatch from release.yml (passing the version explicitly), so resolve-version.sh is no longer used by any workflow. Remove it and its regression test, and drop the now-obsolete shell-tests CI job.
5 tasks
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Collaborator
|
@greptileai review |
Collaborator
Author
Collaborator
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the old Docker-publish version resolver (
resolve-version.sh) and its regression test. Thedocker-publishworkflow no longer uses aworkflow_runtrigger —release.ymlnow dispatches it directly with the version passed as an input — so this script (and the CI job that tested it) is dead code.Related Issue
Closes #282 (contributes the remaining cleanup portion; the auto-publish and build-time work was already merged in commit
20f2c2e— "replace unreliable workflow_run trigger and eliminate QEMU bottleneck").Intend
Issue #282 asks for a reliable, fast automatic Docker publish on release. The auto-trigger and native-ARM speedup are already merged. This PR completes the picture by removing the obsolete
workflow_run-era machinery that nothing references anymore.Changes
.github/scripts/resolve-version.sh(unused by any workflow).tests/ci/resolve-version-test.sh(tested only the deleted script).shell-testsjob from.github/workflows/ci.ymlthat ran that test.Validation
ci.ymlre-parses as valid YAML after the edit.resolve-versionanywhere else in the repo.cargo fmt/clippyare not applicable.release.yml/docker-publish.yml, which are unchanged by this PR.Checklist
cargo fmtor confirmed formatting was not applicable. (Not applicable — no Rust code changed.)cargo clippyor explained why it was not applicable. (Not applicable — no Rust code changed.)AI Usage Declaration
ci.ymledit, validated the result, and drafted this description.ci.ymlremains valid YAML, and confirmed the change does not affect the GHCR publish path.git grep resolve-version→ no matches;python3 -c "import yaml; yaml.safe_load(open('.github/workflows/ci.yml'))"→ OK.Notes for Reviewers
workflow_runresolver. The remaining acceptance criteria (real merge tomainproducing the image, and a measured build-time figure) require an actual release and are out of scope for a code-only PR — please confirm that's acceptable to close Auto-publish Docker image on release and reduce build time #282.The PR appears safe to merge; no outstanding publishing dependency on the removed resolver was found.
Summary
The PR removes an unused Docker version resolver, its regression test, and the CI job that ran the test. The current publishing workflow receives the release version directly.
Reviews (2) · Last reviewed commit: "Merge branch 'develop' into chore/remove..."