Skip to content

chore(ci): remove unused docker version resolver - #358

Merged
NkwaTambe merged 3 commits into
The-AgenticFlow:developfrom
NkwaTambe:chore/remove-docker-version-resolver
Oct 6, 2026
Merged

NkwaTambe merged 3 commits into
The-AgenticFlow:developfrom
NkwaTambe:chore/remove-docker-version-resolver

Conversation

@NkwaTambe

@NkwaTambe NkwaTambe commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Removes the old Docker-publish version resolver (resolve-version.sh) and its regression test. The docker-publish workflow no longer uses a workflow_run trigger — release.yml now dispatches it directly with the version passed as an input — so this script (and the CI job that tested it) is dead code.

Related Issue

Closes #282 (contributes the remaining cleanup portion; the auto-publish and build-time work was already merged in commit 20f2c2e — "replace unreliable workflow_run trigger and eliminate QEMU bottleneck").

Intend

Issue #282 asks for a reliable, fast automatic Docker publish on release. The auto-trigger and native-ARM speedup are already merged. This PR completes the picture by removing the obsolete workflow_run-era machinery that nothing references anymore.

Changes

  • Delete .github/scripts/resolve-version.sh (unused by any workflow).
  • Delete tests/ci/resolve-version-test.sh (tested only the deleted script).
  • Remove the shell-tests job from .github/workflows/ci.yml that ran that test.

Validation

  • ci.yml re-parses as valid YAML after the edit.
  • Confirmed via grep that no workflow or file references resolve-version anywhere else in the repo.
  • No Rust code touched, so cargo fmt/clippy are not applicable.
  • The affected behavior (auto-publish + version resolution) lives in release.yml/docker-publish.yml, which are unchanged by this PR.

Checklist

  • My commit messages are descriptive and scoped to this change.
  • This PR is focused on one issue or one coherent change.
  • I ran cargo fmt or confirmed formatting was not applicable. (Not applicable — no Rust code changed.)
  • I ran cargo clippy or explained why it was not applicable. (Not applicable — no Rust code changed.)
  • I added or updated tests for new behavior or bug fixes, or explained why tests were not needed. (Deleted an obsolete test that exercised deleted code.)
  • I updated documentation for user-facing, operational, or architectural changes. (None needed — this removes internal CI dead code.)
  • I proposed an ADR or called out reviewer attention for architectural changes. (Not an architectural change.)

AI Usage Declaration

  • What AI was used for: This change and PR text were produced with AI assistance. AI identified the dead code, performed the deletion and ci.yml edit, validated the result, and drafted this description.
  • What was verified by a human (contributor): The contributor reviewed the final diff, confirmed the removed files were genuinely unreferenced (via grep) and that ci.yml remains valid YAML, and confirmed the change does not affect the GHCR publish path.
  • Source of truth: Issue Auto-publish Docker image on release and reduce build time #282 — Auto-publish Docker image on release and reduce build time #282
  • Verification evidence: git grep resolve-version → no matches; python3 -c "import yaml; yaml.safe_load(open('.github/workflows/ci.yml'))" → OK.

Notes for Reviewers

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no outstanding publishing dependency on the removed resolver was found.

Summary

The PR removes an unused Docker version resolver, its regression test, and the CI job that ran the test. The current publishing workflow receives the release version directly.

Reviews (2) · Last reviewed commit: "Merge branch 'develop' into chore/remove..."

The docker-publish workflow switched from the workflow_run trigger to a
direct dispatch from release.yml (passing the version explicitly), so
resolve-version.sh is no longer used by any workflow. Remove it and its
regression test, and drop the now-obsolete shell-tests CI job.
@NkwaTambe NkwaTambe self-assigned this Oct 5, 2026
@NkwaTambe NkwaTambe linked an issue Oct 5, 2026 that may be closed by this pull request
5 tasks

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@Christiantyemele

Copy link
Copy Markdown
Collaborator

@greptileai review

@NkwaTambe

Copy link
Copy Markdown
Collaborator Author

https://github.com/greptileai review

@Christiantyemele

Copy link
Copy Markdown
Collaborator

@greptileai review

@NkwaTambe
NkwaTambe merged commit dc6c67e into The-AgenticFlow:develop Oct 6, 2026
12 checks passed
@NkwaTambe
NkwaTambe deleted the chore/remove-docker-version-resolver branch October 6, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-publish Docker image on release and reduce build time

2 participants