fix(merge): gate VESSEL on merge-ready PRs and hold non-submit PRs

[Christiantyemele]

Summary

Only route PRs whose ticket lifecycle is in submit to VESSEL for merge. PRs whose tickets are still in an earlier phase (building, testing, etc.) are held via a new lifecycle Block event instead of stalling the entire queue, so the next assignable ticket can proceed.

This addresses the case where VESSEL repeatedly deferred an approved PR because the lifecycle was not in a merge-ready state, blocking the queue and preventing workspace recycling.

Changes

• config: add Block lifecycle event — records a reason and feedback, enters blocked (recoverable through planning)
• config: add KEY_MERGE_READY_PRS shared-store key
• nexus: pending_prs_ready_for_vessel computes which pending PRs are in submit and holds the rest via Block; persists the merge-ready set
• vessel: prefer the merge_ready_prs handoff over the raw pending queue in prep
• forge template: install and auth gh CLI in the workspace so agents open PRs with gh pr create instead of hand-rolling the REST API
• docker-compose: correct REDIS_URL service host for the controller

Validation

• cargo check -p agent-nexus -p agent-vessel -p config passes
• cargo test -p config (74), cargo test -p agent-nexus (144), cargo test -p agent-vessel (44) all pass, including new tests:
  • test_prep_prefers_merge_ready_prs_handoff
  • held_pending_pr_does_not_block_next_assignable_ticket
  • submit_pending_pr_remains_eligible_for_vessel

Test plan

• PR whose ticket is in submit → passed to VESSEL for merge
• PR whose ticket is in building/earlier → held with a Block lifecycle record, queue continues
• Approved PR in a non-merge-ready lifecycle no longer defers the whole controller pass

Confidence Score: 5/5

The PR appears safe to merge; the latest changes leave no outstanding review finding.

Summary

The PR gates VESSEL handoff on tickets reaching submit, preserves in-flight ticket progress when withholding other PRs, and updates FORGE GitHub authentication and the controller’s Redis default. The latest changes remove an unused Docker version resolver and its dedicated test job.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Pending PRs] --> B[NEXUS checks ticket lifecycle]
    B -->|Submit| C[Merge-ready handoff]
    B -->|Other phase| D[Withhold PR; preserve lifecycle]
    C --> E[VESSEL refreshes against pending queue]
    E --> F[Merge eligibility checks]

Loading

_{Reviews (6) · Last reviewed commit: "Merge branch 'develop' into fix/vessel-m..."}

[Christiantyemele]

@greptileai review

[Christiantyemele]

@greptileai review