tinyRocket: the tag_array override carries the pins and geometry it needs

[oharboe]

Why

This is to stop AI squirrel chasing: a checked-in design file that fails its own format's contract sends an agent (or a human) hunting in the flow for a bug that is in the data.

What

asap7/tinyRocket force-converts tag_array through ADDITIONAL_MEMORIES, because the RTL gives that wrapper no behavioral body: it instantiates a tag_array_ext the sources never define. Detection finds memories by their inferred $mem_v2 cells and tag_array has none, so the override is taken whole (schema.merge: "it must then carry pins and geometry itself to be emittable"). It carried only name, idiomatic and reason, so gen_memories stops in validate_emittable:

schema.SchemaError: memory tag_array: no pins

Fix

The override carries what the module boundary in freechips.rocketchip.system.TinyConfig.v says: one read-write port, rows 4 (addr_w 2), bits 25, and the six RW0 pins, no mask.

Test

flow/scripts/memories/schema_test.py gains TinyRocketTagArrayTest:

• the override taken whole is emittable;
• its pins equal the tag_array module's ports read from the RTL, so the data cannot drift from the design.

Both fail before this change; the memories tests pass after. Note that CI does not run flow/scripts/memories/*_test.py today.

🤖 Generated with Claude Code

[gemini-code-assist]

Code Review

This pull request updates the tag_array memory definition in tag_array.memories with detailed properties and pins, and introduces a unit test in schema_test.py to verify that the override is emittable and matches the RTL. The review feedback suggests making the Verilog module header parser in the test helper more robust by stripping leading whitespace before checking for the module declaration and closing parenthesis.

[openroad-ci]

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 6827978 · Jenkins build #3 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.