fix(docker): reject incomplete OpenROAD builds - #4567
Merged
vvbandeira merged 1 commit intoSep 25, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a check to verify that the OpenROAD binary is built and executable during the Docker build process. The feedback suggests replacing the simple 'test -x' command with an explicit conditional block that outputs a clear error message upon failure, which will improve debuggability in CI/CD pipelines.
Verific integration can succeed while the OpenROAD build silently fails to produce the binary. Check for it explicitly and exit before the image is layered further. Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
vvbandeira
force-pushed
the
ci-image-integrity
branch
from
September 25, 2026 18:49
6f4dc8d to
16c494a
Compare
vvbandeira
merged commit Sep 25, 2026
2bf0c95
into
The-OpenROAD-Project:master
10 of 12 checks passed
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.