fix(util): exit non-zero when uploadMetadata publish fails - #4569
Open
vvbandeira wants to merge 1 commit into
Open
vvbandeira wants to merge 1 commit into
vvbandeira wants to merge 1 commit into
Conversation
A failed Pub/Sub publish printed a warning, and the script exited 0. When the publish credential was rejected with a 401, CI builds passed, but the QoR dashboard received no results. The dashboard baseline then stayed on an old build. Later builds were compared against that old build. They failed on metric changes from many merges, not from their own commit. Exit 1 when the pipeline report or a v1 fallback message fails to publish. CI then shows the upload failure in the build that has it. Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates flow/util/uploadMetadata.py to ensure that Pub/Sub publish failures result in a non-zero exit status, preventing CI builds from passing when data fails to upload. It tracks failed publishes in publish_v1_per_design, updates warning logs to error logs, and exits with an error code if any failures occur. There are no review comments to address, and I have no additional feedback to provide.
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed Pub/Sub publish printed a warning, and the script exited 0. When the publish credential was rejected with a 401, CI builds passed, but the QoR dashboard received no results. The dashboard baseline then stayed on an old build. Later builds were compared against that old build. They failed on metric changes from many merges, not from their own commit.
Exit 1 when the pipeline report or a v1 fallback message fails to publish. CI then shows the upload failure in the build that has it.