-
Notifications
You must be signed in to change notification settings - Fork 1k
ram: integrate OpenSTA for timing and power reporting #10784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tnguy19
wants to merge
20
commits into
The-OpenROAD-Project:master
Choose a base branch
from
tnguy19:ram-sta-integration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
92994ab
ram: integrate OpenSTA for timing and power reporting
tnguy19 697e11f
ram: add dependencies for Bazel checks
tnguy19 0c86fe4
ram: fix buildifier formatting for BUILD file
tnguy19 2e81f71
ram: update so report timing and power called automatically at end of…
tnguy19 6e58b6c
ram: fix clang-format in ram.h
tnguy19 14269c4
ram: add includes for sta::StringSeq and sta::PathEndSeq to fix clang…
tnguy19 83440a4
ram: update golden .ok files to include timing and power report
tnguy19 63c4cfb
ram: update golden files and BUILD for all regression tests
tnguy19 025ef12
ram: use sta units for timing and power log output, update latch tcl …
tnguy19 7f6271e
ram: move reportTimingPower() to public method and add a tcl wrapper …
tnguy19 28fbd8d
ram: fix clang-format and tclfmt lint violations
tnguy19 c121752
ram: restrict timing report to functional real data endpoints like st…
tnguy19 af382e0
ram: add sta/SdcClass.hh include to fix clang tidy bazel
tnguy19 07a3ee1
ram: change reportTimingAndPower to include all non clock pins for an…
tnguy19 06eb442
ram: restrict reportTimingAndPower to non-clock inputs to all outputs
tnguy19 ae83037
ram: retrigger ci build
tnguy19 3c1f2c5
Merge upstream master into ram-sta-integration
tnguy19 ade7484
ram: remove stray local test files and restore upstream test files
tnguy19 2bfbf56
ram: use critical path delay obtained from timing analysis as clock p…
tnguy19 05f1838
ram: add trailing newline to ram.tcl
tnguy19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,6 +31,7 @@ cc_library( | |
| ], | ||
| deps = [ | ||
| "//:ord", | ||
| "//src/dbSta", | ||
| "//src/dbSta:dbNetwork", | ||
| "//src/dpl", | ||
| "//src/drt", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the unconstrained min-path query left unfiltered, designs with primary/clock startpoints at zero arrival can be selected as the “shortest” path; the new goldens all report
RAM minimum path delay: 0.000 ns, which is not a useful RAM min/cycle delay. Please constrain/filter the returned path to real data paths before logging it, otherwise users get a silently misleading minimum-delay report.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some investigation and found that because no
create_clockis defined in these automated RAM test the fastest min path appear to always be through the latch/flip-flop clock pins which will report a value of zero second which is misleading.I added in a check to restrict the pin search to only the functional endpoints (flip-flop/latch D pins and primary Q outputs) since this is more accurate of how the RAMs will perform. This should also works with any RAM sizes and configurations instead of trying to define a specific number of pins that we want to restrict the test to.
Update is made in c121752
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the real solution is just that clock should be excluded and everything else should be included.
You may also need to set clocks to propagated? I'm not sure if that affects the datapath timing.