Skip to content

gpl: revert PR #11553 for momentum reset - #11578

Merged
gudeh merged 1 commit into
The-OpenROAD-Project:masterfrom
gudeh:revert-11553-gpl-momentum-reset
Sep 29, 2026
Merged

gudeh merged 1 commit into
The-OpenROAD-Project:masterfrom
gudeh:revert-11553-gpl-momentum-reset

Conversation

@gudeh

@gudeh gudeh commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

The momentum reset is causing the step length on some private designs to be too small and instances are not moving at all after their 2nd TD iteration.

Revert the changes from #11553 while I search for a solution.

…AD-Project-staging/secure-gpl-momentum-reset-fix"

This reverts commit b2e51b5, reversing
changes made to 3aa45d8.

Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
@gudeh
gudeh requested a review from a team as a code owner September 29, 2026 21:23
@gudeh
gudeh requested a review from LucasYuki September 29, 2026 21:23

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the reset_nesterov_momentum_ logic from the NesterovPlace class and deletes the associated simple01-td-restart test case, as this momentum restart mechanism is no longer required. The test output files have been updated to reflect these changes. I have no feedback to provide.

@gudeh

gudeh commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

I noticed that increasing the minimum step-length from 0.01 to 0.1 makes the issue go away. But I am working on a proper solution with a proper understanding of the whole issue.

if (newStepLength < 0.01) {
stepLength_ = 0.01;
return false;
}

@gudeh
gudeh requested a review from eder-matheus September 29, 2026 21:29
@gudeh

gudeh commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

@jhkim-pii FYI

@jhkim-pii

Copy link
Copy Markdown
Contributor

Oh there is a side effect. Thank you for sharing.

@gudeh
gudeh merged commit b2174f3 into The-OpenROAD-Project:master Sep 29, 2026
21 of 22 checks passed
@gudeh
gudeh deleted the revert-11553-gpl-momentum-reset branch September 30, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants