gpl: revert PR #11553 for momentum reset - #11578
Merged
gudeh merged 1 commit intoSep 29, 2026
Merged
Conversation
LucasYuki
approved these changes
Sep 29, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the reset_nesterov_momentum_ logic from the NesterovPlace class and deletes the associated simple01-td-restart test case, as this momentum restart mechanism is no longer required. The test output files have been updated to reflect these changes. I have no feedback to provide.
Contributor
Author
|
I noticed that increasing the minimum step-length from 0.01 to 0.1 makes the issue go away. But I am working on a proper solution with a proper understanding of the whole issue. OpenROAD/src/gpl/src/nesterovBase.cpp Lines 4392 to 4395 in ff92ebf |
Contributor
Author
|
@jhkim-pii FYI |
Contributor
|
Oh there is a side effect. Thank you for sharing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The momentum reset is causing the step length on some private designs to be too small and instances are not moving at all after their 2nd TD iteration.
Revert the changes from #11553 while I search for a solution.