Conversation
Signed-off-by: Abdulrasheed Abdulmajeed <miloboy188@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request enhances the IP checker's pin routing grid alignment check (LEF-CHK-003) to include cross-layer compatibility verification. It introduces a new LayerAlignmentConstraint structure and applies the Chinese Remainder Theorem to ensure that a single macro translation can simultaneously satisfy alignment constraints across multiple routing layers on the same placement axis. Additionally, a new pass/fail test case check_ip_multilayer_alignment has been added to validate this cross-layer alignment logic. There are no review comments, and I have no feedback to provide.
There was a problem hiding this comment.
Welcome to OpenROAD! Thanks for opening your first PR.
Before we review:
- Contribution Guide: https://openroad.readthedocs.io/en/latest/contrib/GettingInvolved.html
- Build Instructions: https://openroad.readthedocs.io/en/latest/contrib/BuildWithCMake.html
Please ensure:
- CI passes
- Code is properly formatted
- Tests are included where applicable
A maintainer will review shortly!
Summary
Extends
check_ipLEF-CHK-003 so it can detect when minimum-width signal pins on different routing layers cannot be aligned to their track grids with one shared macro translation.The existing check validates each layer independently. This adds the cross-layer constraint discussed in #4872 and in the review thread from #9405.
Implementation
Validation
git diff --checkpasses.Part of #4872