Skip to content

dbSta: check cross-layer pin alignment - #11619

Open
mahjiid wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
mahjiid:fix/check-ip-multilayer-alignment
Open

mahjiid wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
mahjiid:fix/check-ip-multilayer-alignment

Conversation

@mahjiid

@mahjiid mahjiid commented Oct 3, 2026

Copy link
Copy Markdown

Summary

Extends check_ip LEF-CHK-003 so it can detect when minimum-width signal pins on different routing layers cannot be aligned to their track grids with one shared macro translation.

The existing check validates each layer independently. This adds the cross-layer constraint discussed in #4872 and in the review thread from #9405.

Implementation

  • Keep the existing per-layer effective-pitch/GCD validation.
  • Derive the required macro-translation congruence for each checked routing layer.
  • Compare layers that constrain the same placement axis using the generalized Chinese Remainder compatibility condition.
  • Report a warning when no single translation can satisfy both layers.
  • Add a focused LEF/DEF/Tcl regression with one compatible and one impossible multi-layer case.
  • Register the regression in both Bazel and CMake.

Validation

  • git diff --check passes.
  • Commit includes DCO sign-off.
  • Focused regression is registered for CI.
  • A full local OpenROAD build was not run because this Windows machine does not currently have the project Bazel/C++ toolchain installed; CI should exercise the registered test.

Part of #4872

Signed-off-by: Abdulrasheed Abdulmajeed <miloboy188@gmail.com>
@mahjiid
mahjiid requested a review from a team as a code owner October 3, 2026 10:51
@mahjiid
mahjiid requested a review from jhkim-pii October 3, 2026 10:51
@github-actions github-actions Bot added the size/M label Oct 3, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the IP checker's pin routing grid alignment check (LEF-CHK-003) to include cross-layer compatibility verification. It introduces a new LayerAlignmentConstraint structure and applies the Chinese Remainder Theorem to ensure that a single macro translation can simultaneously satisfy alignment constraints across multiple routing layers on the same placement axis. Additionally, a new pass/fail test case check_ip_multilayer_alignment has been added to validate this cross-layer alignment logic. There are no review comments, and I have no feedback to provide.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to OpenROAD! Thanks for opening your first PR.
Before we review:

Please ensure:

  • CI passes
  • Code is properly formatted
  • Tests are included where applicable
    A maintainer will review shortly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant