Repository navigation
Or sta update 1012 - #11726
Or sta update 1012#11726maliberty merged 6 commits into
Conversation
Bump src/sta to the 10/12 upstream OpenSTA update. Upstream OpenSTA changed Network::highestNetAbove and Network::highestConnectedNet to take (and return) const Net*. Update the dbNetwork overrides to match so they still override the base virtuals. Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Upstream OpenSTA changed Network::highestNetAbove to return const Net*. Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves const-correctness in the dbNetwork class by updating the signatures of highestConnectedNet and highestNetAbove to accept and return const Net* pointers. These signature changes are propagated to their implementations, the associated unit tests, and the src/sta submodule reference. There are no review comments, so I have no feedback to provide.
|
secure CI Secure CI http://secure-ci:8080/job/SB/job/secure-update_or_sta_1013/ |
Ouch multiple crashes in TD GPL and repair timing in GRT ! |
Upstream OpenSTA removed the ConcreteParasitics lock; parasitic map entries must now exist before threads build parasitics. The OpenMP loops in estimateWireParasitics and estimateRoutesInParallel start from new, empty parasitics, so concurrent makeParasiticNetwork calls inserted into the shared maps and crashed (e.g. sky130hd/aes in GPL, jpeg in GRT). Call Parasitics::ensureParasitics() before both loops. Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
|
Cause of crash
Fix:
|
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
OpenSTA f861c627 ("required init resolves The-OpenROAD-Project#523") reports INF slack for
an input port with no fanout instead of -input_delay, since it is on no
timing path.
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
|
I reran the secure-ci and the only design that fails- I reran it starting with same synthesized DB from the ORFS artifacts- the QoR ended to be the same as this code does. So likely the synthesis was different in the 2 runs and unrelated to the OpenSTA change |
|
😌 Much more succinct than what I had in my PR. |
Summary
Update OpenSTA to latest upstream 10/13 plus a number of fixes
The-OpenROAD-Project/OpenSTA#422 to be merged before merging this
Type of Change
Impact
Should resolve lock contention in findParasitics
Verification
./etc/Build.sh).