Skip to content

Ship PseudoEditor 2.0: saving that can't overwrite newer work, and a V2 blog post - #30

Merged
The1UNeed merged 1 commit into
mainfrom
t3/ship-readiness-council-review
Nov 19, 2026
Merged

The1UNeed merged 1 commit into
mainfrom
t3/ship-readiness-council-review

Conversation

@The1UNeed

@The1UNeed The1UNeed commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

The app worked, but it wasn't ready to ship. next build refused to run on Next 16.4.3 because of two security advisories. Students could also lose work in several ways: signing in dropped a guest's files, a tab left open could silently overwrite newer work from another tab or device, two tabs overwrote each other's crash-recovery copy, and a data file named something like 成绩.txt broke loading from the cloud.

This fixes those, releases the result as 2.0.0, and adds a blog post about the release.

  • Saves can't overwrite newer work. Each cloud workspace now has a revision number, and Convex refuses a save made from an older one. The tab pauses saving and shows a notice with Reload, which keeps the account's version and adds this device's edited files beside it in "From this device". During the deploy window, saves from the previous web code (which send no revision) still overwrite as before.
  • Guest work is kept on sign-in. On pseudoeditor.dev, a guest's files go into a "Guest" folder in their account, data files included. Files from several practice questions visited before signing in are combined.
  • Account and tab safety.
    • The server refuses any save or read that names a different account from the one signed in.
    • A program run started before sign-in can't overwrite the account's data files when it finishes.
    • Each tab keeps its own crash-recovery copy.
    • Recovery never drops a data file.
    • A workspace that is too large to save in the account now says cloud saving is paused and why.
  • Security: Next.js 16.4.3 → 16.4.5 (GHSA-mfr8-8qww-v76h, GHSA-vc7v-qv4w-wrv8). pnpm audit --prod now reports no known vulnerabilities.
  • V2: all packages are at 2.0.0, and the Explorer shows v2.0.0 instead of 0.1.9-Preview. A new EN/ZH blog post, "PseudoEditor 2.0", covers what shipped in November (Rename Lesson and add syllabus references for IGCSE, AP, and IB #15–Stop autofill crashing the editor, and stop students getting stuck when sign-in is blocked #29 and this PR).

Follow-ups, none of which lose work:

  • A tab left open only learns of a conflict at its next account sync.
  • The Reload button also triggers the browser's leave warning.
  • Two editor windows both left visible can produce duplicate copies.
  • After a conflict, a rename, move, or delete made on this device can be undone. File contents are kept.

Proof: pnpm typecheck, pnpm typecheck:convex, and pnpm lint pass. Tests pass: web 342 (27 new, including a fail-without-fix test for each data-loss bug), compiler 19, workspace 24, Rust 19. pnpm build succeeds. Playwright against the production build passed 19/19 checks with 0 console errors (English and Chinese pages, write/run/INPUT, live errors, flowchart, infinite-loop stop, persistence across reload, phone layout). It also confirmed the post is listed first on /blog, both /blog/pseudoeditor-v2 and /zh/blog/pseudoeditor-v2 render, and the Explorer shows v2.0.0.

GitHub CI passes. The Vercel preview fails for the reason #27 already noted: the branch's new Convex preview deployment has no CLERK_JWT_ISSUER_DOMAIN. The web build itself succeeded. The Convex change is additive (an optional revision field), so existing rows still validate.

Council review

Rounds: 9 (data-safety changes)

Delegate R1 R2 R3 R4 R5 R6 R7 R8 R9
GPT-6.1 Sol (xhigh) 6/10 7/10 7/10 7/10 8/10 8/10 8/10 8/10 9/10
GPT-6.1 Terra (xhigh) 5/10 6/10 6/10 7/10 9/10 9/10 9/10 8/10 9/10
Claude Opus 5.5 (xhigh) — — — — — — — — 9/10

Opus joined once both GPT reviewers reached the 9/10 target.

Reviewed with sol-loop: 2 rounds with gpt-6.2-sol on xhigh, on the version bump and blog post. Round 1 found 11 overstated or inaccurate claims, and all were rewritten in both languages. Round 2's three remaining wording points, plus one new one, were fixed without another round, which sol-loop allows for text-only fixes. One suggestion was declined as too much detail for a release post: telling readers to copy out both versions before refreshing old tabs.

Created with Claude Opus 5.5 in Claude Code (T3 Code). Reviews by gpt-6.1-sol, gpt-6.1-terra, gpt-6.2-sol, and claude-opus-5-5.

🤖 Generated with Claude Code

…V2 blog post

- Cloud saves carry a revision; a stale tab or device is refused (409) and asked to Reload, which keeps both versions. Older web deployments keep last-write-wins during the deploy window.
- Guest work is imported into a "Guest" folder on sign-in; each tab keeps its own crash-recovery checkpoint; saves are refused when they name a different account; a run started before sign-in can't overwrite the account's data files; non-ASCII data-file names load from Convex.
- Next.js 16.4.3 -> 16.4.5 for GHSA-mfr8-8qww-v76h and GHSA-vc7v-qv4w-wrv8.
- Version 2.0.0; the explorer shows v2.0.0 instead of 0.1.9-Preview.
- New EN/ZH blog post "PseudoEditor 2.0".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
pseudoeditor.dev Error Error Nov 19, 2026 10:45am UTC

Request Review

@cursor

cursor Bot commented Nov 19, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: d66ef186-ecc8-4580-a580-15694f9960ab)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T10:47:06.587128Z d3b57ab PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@The1UNeed
The1UNeed merged commit d588181 into main Nov 19, 2026
6 of 7 checks passed

This branch had an error being deployed

1 failed deployment
Preview — d3b57ab4 Deployed Nov 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant