Repository navigation
Ship PseudoEditor 2.0: saving that can't overwrite newer work, and a V2 blog post - #30
Merged
Merged
Conversation
…V2 blog post - Cloud saves carry a revision; a stale tab or device is refused (409) and asked to Reload, which keeps both versions. Older web deployments keep last-write-wins during the deploy window. - Guest work is imported into a "Guest" folder on sign-in; each tab keeps its own crash-recovery checkpoint; saves are refused when they name a different account; a run started before sign-in can't overwrite the account's data files; non-ASCII data-file names load from Convex. - Next.js 16.4.3 -> 16.4.5 for GHSA-mfr8-8qww-v76h and GHSA-vc7v-qv4w-wrv8. - Version 2.0.0; the explorer shows v2.0.0 instead of 0.1.9-Preview. - New EN/ZH blog post "PseudoEditor 2.0". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: d66ef186-ecc8-4580-a580-15694f9960ab) |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app worked, but it wasn't ready to ship.
next buildrefused to run on Next 16.4.3 because of two security advisories. Students could also lose work in several ways: signing in dropped a guest's files, a tab left open could silently overwrite newer work from another tab or device, two tabs overwrote each other's crash-recovery copy, and a data file named something like成绩.txtbroke loading from the cloud.This fixes those, releases the result as 2.0.0, and adds a blog post about the release.
pnpm audit --prodnow reports no known vulnerabilities.v2.0.0instead of0.1.9-Preview. A new EN/ZH blog post, "PseudoEditor 2.0", covers what shipped in November (Rename Lesson and add syllabus references for IGCSE, AP, and IB #15–Stop autofill crashing the editor, and stop students getting stuck when sign-in is blocked #29 and this PR).Follow-ups, none of which lose work:
Proof:
pnpm typecheck,pnpm typecheck:convex, andpnpm lintpass. Tests pass: web 342 (27 new, including a fail-without-fix test for each data-loss bug), compiler 19, workspace 24, Rust 19.pnpm buildsucceeds. Playwright against the production build passed 19/19 checks with 0 console errors (English and Chinese pages, write/run/INPUT, live errors, flowchart, infinite-loop stop, persistence across reload, phone layout). It also confirmed the post is listed first on /blog, both /blog/pseudoeditor-v2 and /zh/blog/pseudoeditor-v2 render, and the Explorer shows v2.0.0.GitHub CI passes. The Vercel preview fails for the reason #27 already noted: the branch's new Convex preview deployment has no
CLERK_JWT_ISSUER_DOMAIN. The web build itself succeeded. The Convex change is additive (an optionalrevisionfield), so existing rows still validate.Council review
Rounds: 9 (data-safety changes)
Opus joined once both GPT reviewers reached the 9/10 target.
Reviewed with sol-loop: 2 rounds with gpt-6.2-sol on xhigh, on the version bump and blog post. Round 1 found 11 overstated or inaccurate claims, and all were rewritten in both languages. Round 2's three remaining wording points, plus one new one, were fixed without another round, which sol-loop allows for text-only fixes. One suggestion was declined as too much detail for a release post: telling readers to copy out both versions before refreshing old tabs.
Created with Claude Opus 5.5 in Claude Code (T3 Code). Reviews by gpt-6.1-sol, gpt-6.1-terra, gpt-6.2-sol, and claude-opus-5-5.
🤖 Generated with Claude Code