Add typing to worker module - #38
Open
JuanTecedor wants to merge 2 commits into
Open
Conversation
JuanTecedor
commented
Jun 16, 2026
| name: str | list[str], | ||
| default: Any = None, | ||
| message: str | None = None, | ||
| ) -> Any: |
Contributor
Author
There was a problem hiding this comment.
Without validation I'm not convinced it is worth it to narrow the return type beyond Any, but we could narrow it down to a JSON subset dict | list | str | int | float | bool | None (https://docs.python.org/3/library/json.html#json.JSONEncoder).
Other option is to break compatibility and add a function with a expected_type param that errors if an isinstance check fails, for example.
JuanTecedor
commented
Jun 16, 2026
JuanTecedor
commented
Jun 16, 2026
|
|
||
|
|
||
| class Worker: | ||
| READ_TIMEOUT = 3 # seconds |
Contributor
Author
There was a problem hiding this comment.
This looks unused. Again, chance to break compatibility
JuanTecedor
commented
Jun 16, 2026
JuanTecedor
commented
Jun 16, 2026
Kamforka
self-requested a review
June 20, 2026 11:02
JuanTecedor
marked this pull request as ready for review
June 22, 2026 18:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #37.
I've tried to keep types wide for now.
TODO: