Standard i18n wiring + POT template + SPDX alignment - #18
Merged
Merged
Conversation
added 3 commits
September 22, 2026 19:59
Wire load_plugin_textdomain('mikesoft-teamvault') on init so WordPress.org
language packs in languages/ are picked up; keep the bundled it/fr/es/de
runtime maps as fallback. Ship languages/mikesoft-teamvault.pot (309 strings)
with regeneration notes and GlotPress handoff in docs/developer/i18n.md.
Align SPDX license strings to GPL-2.0-or-later (plugin header, readme.txt,
README badges/license text); LICENSE text untouched per its no-modification
clause.
Since WP 4.6, wordpress.org-hosted plugins get GlotPress language packs auto-loaded from WP_LANG_DIR, so the manual load_plugin_textdomain() call in MSTV_I18n::init() is unnecessary (Requires at least is 6.0). Per https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#plugins-on-wordpress-org and https://make.wordpress.org/polyglots/handbook/plugin-theme-authors-guide/#once-your-project-is-translated (community packs take precedence since WP 4.7). The bundled gettext-filter fallback maps are kept so the it/fr/es/de admin UI still works when no language pack is installed. Also fixes the pre-existing Plugin Check error by bumping readme.txt Tested up to 7.0 -> 7.1, verified against the current stable (7.1.2) via https://api.wordpress.org/core/version-check/1.7/. NOTE: owner smoke-test on WP 7.1 is still due.
PDMReleaseMetadataTest pinned the stale 'Tested up to: 7.0' value that Plugin Check flags (current stable is 7.1 per version-check API); the f362349 readme bump to 7.1 broke test_release_metadata_matches_wordpress_7_release on PHP 8.2/8.3/8.4 (run 35768006906, 1 failure each: pattern /^Tested up to:\s*7\.0\s*$/m vs actual 'Tested up to: 7.1'). Align the constant with the corrected readme; no behavior change. Owner smoke-test on WP 7.1 still due.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MSTV_I18n::init()(runs oninitviaMSTV_Bootstrap::init_services()) now callsload_plugin_textdomain('mikesoft-teamvault', false, dirname(plugin_basename(__FILE__), 2) . '/languages'), so WordPress.org/GlotPress language packs are picked up. The bundled it/fr/es/de runtime maps stay untouched as a fallback via the existinggettextfilter.languages/mikesoft-teamvault.pot(309 strings,#:file:line references, Plural-Forms header). wp-cli was unavailable in the authoring environment, so it was produced with a documented equivalent extractor (same function set + domain filter);docs/developer/i18n.mdrecords the canonicalwp i18n make-potregeneration command.docs/developer/i18n.md(loading, POT regen, handoff steps, fallback-map policy); linked from the README Documentation Map.GPL-2.0-or-laterin the plugin header,readme.txt, root + localized README badges and root README license text.composer.jsonandCITATION.cffalready used it. TheLICENSEfile text is deliberately untouched (the GPL text itself forbids modification).Verification
php -l,composer validate, PHPUnit and Plugin Check left to CI, which already gatesmain.No Issues/branch-protection/SVN changes. Never merge from this PR — maintainer review required.