Repository navigation
release: 5.0.0 - #41
Merged
Merged
Conversation
A major because the themeparks-backfill CSV header changed: four implausibleWaits columns now sit in the middle of it, so a reader that takes columns by position gets the wrong ones. The models are regenerated from the current spec. Same 45 columns as the JavaScript SDK 9.0.0. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
cubehouse
marked this pull request as ready for review
October 31, 2026 11:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release 5.0.0. It is a major because the
themeparks-backfillCSV header changed: fourimplausibleWaitscolumns now sit in the middle of it (45 columns, up from 41), so a reader that takes columns by position gets the wrong ones. This follows the 4.0.0 changelog, which treats a header change as a major. The library API is backward compatible, and the models are regenerated from the current spec.Ships with JavaScript SDK 9.0.0, which writes the same 45 columns.
tests/fixtures/csv_contract.jsonis byte-identical in both repos.Evidence
pyproject.tomlanduv.locksay 4.1.0, andCHANGELOG.mdhas an[Unreleased]section.pytest tests/unitgives 457 passed, with clean ruff and mypy. Version inpyproject.tomlanduv.lockis 5.0.0.Merge Danger
Door: one-way once tagged. Merging this PR is two-way; the tag
v5.0.0triggers the publish workflow, and a published version number cannot be reused, and a bad release can only be yanked.Blast Radius: users of
themeparks-backfill. The CSV header changes, and a backfill file started by an earlier version is refused on resume.Tag
v5.0.0after merging, together withv9.0.0on the JavaScript SDK.🤖 Generated with Claude Code