Repository navigation
fix(europapark): report rides the feed drops overnight as CLOSED - #689
Merged
Merged
Conversation
Around midnight local time the waiting-times feed stops listing rides for the main park, Rulantica and Traumatica, keeping only restaurants and the virtual-queue entries. The rides reappear one by one before opening, so from midnight to early morning about a third of the destination's live entities vanished from live data instead of reading CLOSED. Rides the feed listed in the last 7 days are now remembered. While a ride's own park is outside its published hours (main park: live calendar, falling back to seasons; other parks: seasons, from yesterday so a post-midnight close counts), a remembered ride the feed no longer lists is reported CLOSED. Rides the feed does list are never touched, an absent ride inside published hours is still left out, and nothing is carried when a park's hours cannot be read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Around midnight Europe/Berlin the Europa-Park waiting-times feed stops listing rides for the main park, Rulantica and Traumatica. It keeps only restaurants (all closed) and the virtual-queue entries. Rides reappear one by one before opening (from about 07:00 local). Overnight, about a third of the destination's live entities (151 to 102) disappeared from
buildLiveDataoutput instead of readingCLOSED. A consumer that treats a missing entity as removed loses those rides' live state every night.Fix
src/parks/europapark/europapark.tsrememberRides()keeps the rides the feed listed in the last 7 days (entity id to last-seen time, cached undereuropapark:recentRideIds)._carryForwardAbsentRides()runs after the wait-time passes. While a ride's own park is outside its published hours, a remembered ride the feed no longer lists is emitted as{status: 'CLOSED'}.insideMainParkHours), falling back to the seasons feed.insideSeasonHours), starting from yesterday so a closing time after midnight counts.222/333entries win);_applyMainParkClosure, so closed-day handling is unchanged.Tests
__tests__/overnightRideDrop.test.tsreplays the real 2026-09-28 fixtures with a night feed derived by removing every ride entry:CLOSEDovernight, across all three parks;rememberRides,insideMainParkHoursandinsideSeasonHours.With the carry-forward disabled, 4 of the new tests fail (the overnight, three-park, per-park-hours and calendar-fallback cases). Full suite: 4116 passed, 1 skipped. Typecheck clean.