Conversation
Signed-off-by: Mr.Dong <1042542469@qq.com>
hsliuustc0106
left a comment
There was a problem hiding this comment.
Reviewed and verified locally at 11f73ea.
cargo fmt --all --check— cleancargo clippy -p omni-jev --all-targets --locked -- -D warnings— cleancargo test -p omni-jev --test frontend --locked— 12 passed, matching the count reported in the PR description
The three new tests assert real behavior at the transport boundary rather than tautologies: the decision fixtures lock in byte-for-byte preservation in both directions, the invalid-route cases verify the router's 405/404 semantics and that rejected requests never reach the backend (the mock worker records everything through a fallback handler, so that assertion is meaningful), and the prefix + query test covers query-string forwarding under a /worker backend prefix, complementing the existing health-path test. The scope matches #46's proposed first contribution, so closing it on merge is reasonable.
Two non-blocking nits, no changes required:
- The new "Frontend API tests" CI step runs tests that
cargo test --workspacealready runs one step later, so it duplicates coverage for the sake of readable failures. The issue explicitly asked for this, so keeping it is fine — just noting the trade-off. round_trips_decision_fixturesindexesseen[0]without aseen.len() == 1check, unlike its sibling tests. Purely stylistic; a failure would still surface.
One housekeeping note: CI currently shows "no checks reported" because this PR touches .github/workflows/ci.yml from a fork — the workflow runs are held until a maintainer approves them in the Actions tab.
Propose
Close #46
Test Plan
System1-Omni Version / Commit:
11f73eaTest Result
cargo fmt --all --checkcargo clippy --workspace --locked --all-targets -- -D warningscargo test -p omni-jev --test frontend --locked— 12 passedcargo test --workspace --lockedcargo build --workspace --release --lockedGPU kernel tests were ignored because this environment has no GPU/CUDA runtime.
Self-review
Before marking this PR ready for review or requesting maintainer review, complete
the self-review checklist.
Keep the PR in draft while this work is incomplete.
For agent assistance, use the optional precheck-pr skill.