Skip to content

fix(web): a wrapped parent's open child drops the shared topic too - #1024

Merged
badcuban merged 1 commit into
mainfrom
fix/wrapped-child-short-title
Nov 20, 2026
Merged

badcuban merged 1 commit into
mainfrom
fix/wrapped-child-short-title

Conversation

@badcuban

Copy link
Copy Markdown
Collaborator

The sidebar shortens a started thread's title when its siblings share a topic ("Pull Station: Android toolchain" becomes "Android toolchain"), but only under a live parent. Under a wrapped parent, the child open in the chat still showed its full title.

Wrapped rows (InboxDoneRow) now carry the same childShortTitles, worked out over the parent's whole family, and the open child's row uses them. Hover and screen readers keep the full title, as on live rows.

Tests: the sidebar short-title test gained a wrapped family whose open child reads the short title.

The sidebar shortened a started thread's title when its siblings share a
topic, but only under a live parent. Under a wrapped parent, the child open
in the chat still showed its full title. Wrapped rows now carry the same
childShortTitles, worked out over the parent's whole family, and the open
child's row uses them.
@vercel

vercel Bot commented Nov 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
threadlines Skipped Skipped Nov 20, 2026 7:02pm UTC

Request Review

@badcuban
badcuban enabled auto-merge November 20, 2026 19:05
@badcuban
badcuban added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit 394ebbb Nov 20, 2026
23 checks passed
@badcuban
badcuban deleted the fix/wrapped-child-short-title branch November 20, 2026 19:12

This branch was previously deployed

1 inactive deployment
Preview — 77d9706e Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant