Skip to content

fix(web): custom-sorted inbox groups keep their place when their top thread goes - #1028

Merged
badcuban merged 1 commit into
mainfrom
fix/inbox-custom-group-order
Nov 21, 2026
Merged

badcuban merged 1 commit into
mainfrom
fix/inbox-custom-group-order

Conversation

@badcuban

Copy link
Copy Markdown
Collaborator

Closes #1015.

In Custom sort with the inbox grouped by project or computer, a group you never dragged sat wherever its first thread fell in the custom order. Wrapping, archiving or pinning that thread could make another group jump ahead of it.

Custom sort now remembers where it first showed each group, in a new per-device setting (inboxCustomGroupOrder). It's kept apart from the dragged group order, so Recent and the other sorts still move undragged groups with their first row. A group new to the list goes last, and dragged groups still win. "Use automatic order" on a group header (now offered when Custom sort remembers places) and "Reset custom order" clear the remembered places, so groups take them afresh from the current list.

The submitter's patch saved discovered groups into the dragged order, which would have frozen groups in every sort, and also saved every new thread into the custom order, which the existing "unplaced threads go last" rule already covers. This takes the group half only.

Known limits: on the first run, a computer that loads after the active one has its groups placed last once. Two windows discovering different new groups at the same moment can lose one group's remembered place (the dragged order has the same race).

Checked: fmt, lint, typecheck, Sidebar logic tests (new regression test), web and desktop settings tests, full web browser suite.

…thread goes

In Custom sort with the inbox grouped by project or computer, a group the
user never dragged sat wherever its first thread fell in the custom order,
so wrapping, archiving or pinning that thread could make another group
jump ahead of it (#1015).

Custom sort now remembers where it first showed each group, in a new
device setting (inboxCustomGroupOrder) kept apart from the dragged order,
so the other sorts still move undragged groups with their first row. A
group new to the list goes last. Dragged groups still win. "Use automatic
order" (now offered when Custom sort remembers places) and "Reset custom
order" clear the remembered places so groups take them afresh.

Closes #1015
@vercel

vercel Bot commented Nov 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
threadlines Skipped Skipped Nov 20, 2026 8:49pm UTC

Request Review

@badcuban
badcuban added this pull request to the merge queue Nov 21, 2026
Merged via the queue into main with commit 7153476 Nov 21, 2026
23 checks passed
@badcuban
badcuban deleted the fix/inbox-custom-group-order branch November 21, 2026 00:05

This branch was previously deployed

1 inactive deployment
Preview — d72c5234 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Custom Inbox groups jump when a thread is added or removed

1 participant