Repository navigation
test(web): steady the room-pills and panel-swipe tests on busy CI machines - #1029
Merged
Merged
Conversation
…hines The room-pills test focused a pill while the model picker's last search-box focus retries (one frame, one tick) were still pending; on a busy machine they ran after and took the arrow key. It now lets them pass first. Reproduced by holding those retries until after the pill was focused. The panel-swipe test swiped an element it had looked up before the tab reorder above finished re-rendering. It now swipes the panel as it is just then, once the point under the finger is the panel's, and names what it found if the swipe still doesn't close it. Not reproduced locally; inferred.
A missing hit passed the check, and the gesture went to the panel by reference. The element under the finger must now be inside the agents panel, and the swipe starts on it.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two browser tests kept failing intermittently on CI and in the merge queue (#1010 and #1026 both bounced on them), and they fail on main too.
Room pills ("picks who a room message goes to from the agent pills"): when the model picker opens or re-renders, it focuses its search box, then once more a frame later and once more on the next tick. On a busy CI machine those last two tries ran after the test had focused a pill, so the arrow key went to the search box. Reproduced exactly by holding those tries until after the pill was focused. The test now lets them pass first: two frames and a zero timeout. That's enough because the browser runs frame callbacks and equal timers in the order they were scheduled. The app keeps its retries, since they're what take focus back from the message box after
/model.Panel swipe ("closes the overlay panel with a finger pushing it right"): the swipe looked up the agents panel before the tab reorder above it had finished re-rendering, so on a busy machine the gesture could land on a replaced element or a covered spot. The test now waits until the element really under the finger is inside the agents panel, then starts the swipe on that element. If it still doesn't close, the failure message says what it found. This one never reproduced locally under CPU throttling, a page-thread hog, or 8 copies at once under load, so the cause is inferred.
Test files only. The full web browser suite passes (1,158 tests).