Repository navigation
fix(devices): list the iPhone Duo and draw its cover's camera hole where it is - #1033
Merged
Merged
Conversation
…ere it is The iPhone Duo runs on a runtime made for it (iOS-27-2-iPhone19-4), and the never-booted simulator listing only accepted plain iOS-27-2 names, so a fresh Duo never appeared in the Device tab. The listing now accepts a model suffix and still reports iOS 27.2. The Duo's cover was drawn with the iPhones' centered Dynamic Island; the real cover has a round camera hole near the top right. Measured on the live simulator and drawn there.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 21, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iPhone Duo couldn't be used in the Device tab, and its cover was drawn with the wrong cutout.
The Duo never appeared in the device list. The Duo runs on an iOS runtime made only for it:
iOS-27-2-iPhone19-4(build 24B91016s). Xcode's regular iOS 27.2 runtime (24B8117) lists the Duo as unsupported. Our listing of never-booted simulators accepted only plain runtime names likeiOS-27-2, so a fresh Duo was skipped. It now also accepts a runtime with a model suffix, and still reports the version as "iOS 27.2". The listing test covers it and fails without the fix.The cover cutout was wrong. The cover was drawn with the iPhones' centered Dynamic Island. The real cover has a round camera hole near the top right. I measured it on the live simulator's framebuffer: 111 px across, centered at 1254 × 143 px of 1398 × 2034, at 3x. The frame now draws it there, through an optional
centerXon punch-hole cutouts.Checked live on this Mac, with the Duo runtime installed via
xcodebuild -downloadPlatform iOS, in an isolated Threadlines stack:vp fmt,vp lintandvp run typecheckare clean. The server device tests, web device tests and Device browser tests pass.