Skip to content

test(web): steady the usage bar pace test on busy CI machines - #1034

Merged
badcuban merged 1 commit into
mainfrom
fix/flaky-usage-pace-test
Nov 21, 2026
Merged

badcuban merged 1 commit into
mainfrom
fix/flaky-usage-pace-test

Conversation

@badcuban

Copy link
Copy Markdown
Collaborator

The usage bar pace test in ContextWindowMeter.browser.tsx failed now and then on CI with "found

Codex usage". After clicking a usage row it checked that the popup was gone from the page. The popup leaves the page only after its fade-out, and that needs animation frames. A busy CI tab can go seconds without drawing one.

The test now checks that the meter button's aria-expanded is false. That flips as soon as the row closes the popover, with or without frames.

Reproduced by stubbing requestAnimationFrame right before the click: the old check failed with the CI message every time, and the new check passed 6 of 6. Test-only change.

The test checked that the usage popup was gone from the page after
clicking a row. The popup leaves only after its fade-out, which needs
animation frames. A busy CI tab can go seconds without drawing one, so
the popup was still there when the check gave up.

Check the meter button's aria-expanded instead. It turns false as soon
as the row closes the popover, frames or not.
@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
threadlines Skipped Skipped Nov 21, 2026 1:33am UTC

Request Review

@badcuban
badcuban added this pull request to the merge queue Nov 21, 2026
Merged via the queue into main with commit 3a25bad Nov 21, 2026
23 checks passed
@badcuban
badcuban deleted the fix/flaky-usage-pace-test branch November 21, 2026 03:17

This branch was previously deployed

1 inactive deployment
Preview — 86597a8b Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant