Repository navigation
test(web): steady the usage bar pace test on busy CI machines - #1034
Merged
Merged
Conversation
The test checked that the usage popup was gone from the page after clicking a row. The popup leaves only after its fade-out, which needs animation frames. A busy CI tab can go seconds without drawing one, so the popup was still there when the check gave up. Check the meter button's aria-expanded instead. It turns false as soon as the row closes the popover, frames or not.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The usage bar pace test in
ContextWindowMeter.browser.tsxfailed now and then on CI with "foundThe test now checks that the meter button's
aria-expandedisfalse. That flips as soon as the row closes the popover, with or without frames.Reproduced by stubbing
requestAnimationFrameright before the click: the old check failed with the CI message every time, and the new check passed 6 of 6. Test-only change.