Repository navigation
Missing event locations - #69
Merged
Merged
Conversation
merged with staging
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolve conflicts with staging: - sync-inbox-engine: keep the location resolver and shared `now`; port staging's rule that ended events stay published into shouldPublishEvent (new wasPublished parameter, with a test). - events.ts / edit-event-form / feed.ts: keep both sides (required host org and cover preset from staging, manual-location tracking and locationText from this branch). - Migrations: staging's 0007_serious_arachne comes first; replace this branch's 0007-0010 with one regenerated 0008_event_location_resolution. Backfill location_resolution before NOT NULL, marking synced events with a venue as 'engine' (not 'manual', which froze them against sync updates), and copy legacy tba detail into location_text. - feed-recommendations.db.test: add locationResolution to fixture inserts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The previous code kept a "Room N" from the old venue, so moving an event from McCosh Room 50 to Frist showed "Frist Campus Center · Room 50". The edit form has no room field to correct it, so drop the detail instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issues for ticket TIG-307. Preserves original event location text and resolves locations using aliases, campus map data, and conservative fuzzy matching. Manual location corrections survive InboxEngine syncs.
Includes an opt-in flag for publishing eligible events without a location and a CLI for reviewing and fixing unresolved locations.