Skip to content

Missing event locations - #69

Merged
yubimamiya merged 16 commits into
stagingfrom
missing-event-locations
Nov 15, 2026
Merged

yubimamiya merged 16 commits into
stagingfrom
missing-event-locations

Conversation

@ryanadalal

Copy link
Copy Markdown

Fixed issues for ticket TIG-307. Preserves original event location text and resolves locations using aliases, campus map data, and conservative fuzzy matching. Manual location corrections survive InboxEngine syncs.

Includes an opt-in flag for publishing eligible events without a location and a CLI for reviewing and fixing unresolved locations.

ryanadalal and others added 16 commits November 4, 2026 17:59
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolve conflicts with staging:
- sync-inbox-engine: keep the location resolver and shared `now`; port
  staging's rule that ended events stay published into shouldPublishEvent
  (new wasPublished parameter, with a test).
- events.ts / edit-event-form / feed.ts: keep both sides (required host
  org and cover preset from staging, manual-location tracking and
  locationText from this branch).
- Migrations: staging's 0007_serious_arachne comes first; replace this
  branch's 0007-0010 with one regenerated 0008_event_location_resolution.
  Backfill location_resolution before NOT NULL, marking synced events with
  a venue as 'engine' (not 'manual', which froze them against sync
  updates), and copy legacy tba detail into location_text.
- feed-recommendations.db.test: add locationResolution to fixture inserts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The previous code kept a "Room N" from the old venue, so moving an event
from McCosh Room 50 to Frist showed "Frist Campus Center · Room 50". The
edit form has no room field to correct it, so drop the detail instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@yubimamiya
yubimamiya merged commit 03dd7f0 into staging Nov 15, 2026
1 check passed
@yubimamiya
yubimamiya deleted the missing-event-locations branch November 15, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants