Skip to content

Add read-only TigerDraw MCP service with verified floor-plan previews - #41

Open
jon3350 wants to merge 3 commits into
mainfrom
feat/tigerdraw-mcp
Open

jon3350 wants to merge 3 commits into
mainfrom
feat/tigerdraw-mcp

Conversation

@jon3350

@jon3350 jon3350 commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Add a standalone, read-only MCP service exposing six tools for buildings, room search/details, images, reviews, and floor plans. Current room data comes from TigerDraw public APIs, with normalized static fallback, duplicate source IDs, explicit field conflicts, bounded results, and untrusted review handling.

TigerDraw owns PDF originals and verified first-page previews. Catalog generation validates PDF/PNG hashes. Public static previews require no runtime rendering or database access.

Validation

  • 32 Bun tests, including five Python preview-generation fault tests
  • MCP type checking and reproducible catalog generation
  • Production guards for required access tokens and public asset origins
  • Tracked-file credential/local-artifact audit passed

Deployment

Deploy the MCP service and static preview assets on TigerDraw before enabling PI. Configure the systemd service and nginx /mcp route; set MCP_ACCESS_TOKEN to match PI's TIGERDRAW_MCP_TOKEN. No database credentials are required. Poppler is needed only for regenerating previews.

Companion PI PR: TigerAppsOrg/pi#51

Screenshots

image image image image

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T22:47:43.300026Z f7c1615 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f7c1615782

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread mcp/src/data/service.ts
Comment on lines +255 to +257
const reviewQuery = {
building_name: building.review_name,
room_no: room.room_no,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve the stored building casing for review lookups

For reviews submitted under the room/UI spelling (for example, Blair), this sends BLAIR because the generated catalog sets review_name using key(name). The existing /get_reviews route compares Reviews.building_name with exact equality (routes.py:88-92), while /submitReview persists the incoming titlecase building name unchanged (routes.py:796-807,856-858). The endpoint therefore returns valid no-review markup, and MCP reports available: true with an empty review list even when the live room record has a nonzero num_reviews; use the stored spelling or retry the titlecase form rather than unconditionally uppercasing it.

Useful? React with 👍 / 👎.

Comment thread mcp/src/data/client.ts
Comment on lines +97 to +100
let pending = this.inFlight.get(url);
if (!pending) {
pending = this.request(url, route === "/get_reviews", deadline);
this.inFlight.set(url, pending);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Let later callers use their own request deadline

When an identical URL is first requested by a caller with little time remaining—such as a campus search nearing its deadline—and then by a fresh tool call, the second caller reuses a request whose abort timeout and retry loop were fixed to the first caller's deadline. That shared request can abort almost immediately, making the fresh call fail or use static fallback despite having nearly ten seconds left; after a shared request constrained by another caller fails, retry it using the current caller's deadline or avoid baking the initiating caller's deadline into the coalesced transport.

Useful? React with 👍 / 👎.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant