Skip to content

Fix deployment backup connection handling - #20

Merged
DIodide merged 1 commit into
mainfrom
fix/deploy-backup-connection
Nov 20, 2026
Merged

DIodide merged 1 commit into
mainfrom
fix/deploy-backup-connection

Conversation

@DIodide

@DIodide DIodide commented Nov 20, 2026

Copy link
Copy Markdown
Member

The first deployment stopped safely before switching production because pg_dump treated a connection URI in PGDATABASE as a literal database name. Keep database name, host, user, password and TLS options in their separate libpq environment variables, and capture backup diagnostics so errors cannot disclose credentials.

Regression tests cover encoded credentials, redacted failure handling, and an optional real PostgreSQL dump. All three passed locally, including the real dump. The exposed credential was rotated and the failed workflow logs removed. The corrected root-owned deployment script is being installed before retrying production.

@DIodide
DIodide merged commit 501a777 into main Nov 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant