Repository navigation
Harden audit outcomes, rule loading, and Ollama testability - #8
Merged
Merged
Conversation
Distinguish tool failures from review verdicts (exit 0/1/2), move system rule policy into Core, inject HttpClient for orchestrator tests, and sort rule/target enumeration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuditOutcome(exit0passed,1review required,2failed); skip critique persistence on tool failureAuditEngine.LoadSystemRulesAsyncand centralize path validation; batch mode shares CLI error handling with sniffHttpClientintoOllamaAiOrchestratorwith fake-handler unit tests; sort rule and target enumeration for deterministic promptsTest plan
dotnet testonCodeSmellAuditor.slnx(Release): 79 passing0when every audited target reportsStatus: COMPLIANT1when any target reportsStatus: REVIEW REQUIREDand none are tool failures2when Ollama is unreachable or returns an empty/error stream, and no new critique file appears underWorkstationStorage/Reports/2with a clean ERROR line (no unhandled crash) for a missing--stackfolder in batch modesniff-systemstill loadsRules/Architecture/plus optional--stackpacks fromRules/Stacks/