Skip to content

Fix Desktop refresh scroll, locale status, and Save - #7

Merged
TimoKuronen merged 1 commit into
masterfrom
fix/desktop-refresh-and-save
Sep 24, 2026
Merged

TimoKuronen merged 1 commit into
masterfrom
fix/desktop-refresh-and-save

Conversation

@TimoKuronen

@TimoKuronen TimoKuronen commented Sep 24, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Keep entry-grid scroll position by syncing row view-models in place instead of clearing the list on Approve/Invalidate/refresh
  • Always refresh Locales column statuses after apply (including pending edits when changing selection) so Stale matches the editor
  • Disable Save unless the catalog is dirty and already has a saved path; first persist stays on Save As

Test plan

  • Approving or invalidating a selected entry near the bottom of a scrollable catalog keeps selection and does not jump the grid to the top
  • After changing source text on an Approved translation and applying edits, the Locales column shows Stale in sync with the editor
  • Pending source edits applied by changing selection update that rows Locales column to Stale without a separate Apply click
  • Save stays disabled for a new unsaved catalog; Save As creates the path; Save enables only while dirty afterward
  • Save stays disabled for an opened clean catalog and enables after an edit
  • dotnet test: 118 passing

…ment.

- Sync entry rows in place so Approve/Invalidate keeps grid scroll
- Always update Locales column after apply, including pending selection saves
- Enable Save only when the catalog is dirty and already has a path
@TimoKuronen
TimoKuronen merged commit 1c8d868 into master Sep 24, 2026
1 check passed
@TimoKuronen
TimoKuronen deleted the fix/desktop-refresh-and-save branch September 24, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant