Repository navigation
Keep wire speakers on unauthenticated sealed history - #227
Merged
Merged
Conversation
Legacy/archive cache hits were clearing sender id to empty "Saved message", so continues() collapsed a back-and-forth DM into one monologue. Co-authored-by: Cursor <cursoragent@cursor.com>
itz4blitz
force-pushed
the
fix/legacy-saved-speaker-attribution
branch
from
November 8, 2026 20:01
7e3929b to
8745c13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Unauthenticated sealed cache hits (device-link archive / decrypt fallback) were clearing sender.id and labeling every row Saved message. continues() then treated those empty ids as the same speaker, so a back-and-forth DM rendered as one monologue under the chat title. Mapping now keeps the wire author for display (still saved_history, edits still blocked), and empty ids no longer group.
Type
Platforms
Proof
Scenario: e2e/scenarios/legacy-saved-speakers
Lab run:
Compatibility
Older servers unchanged. Client-only mapping of existing sealed history rows.
Risk and rollback
Wrong wire authors could show on unauthenticated history until MLS auth returns; edits stay blocked via saved_history. Revert this PR.
Release note
Encrypted history from a linked device keeps who said what instead of one Saved message wall.