Repository navigation
Conversation
…s name things plainly.
…expiry pass with nothing to expire writes nothing.
…ile sheds its conflict's leftovers.
… the list, the telegram chip survives a switch, and a forum landing answers only while it is current.
…es the demo's forum on three desktops, and the prefs keep the telegram chip across a switch.
…r, an even indent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
A person can now hold the mic and record, letting go stops, when push-to-talk is on. The Telegram forum landing has its quality-gate scenario, and the expiry pass writes nothing when nothing ran out.
This branch is the Telegram wave 3.6 rebased onto current main. Most of the wave's earlier content landed already through #175 (TTL expiry, forum landing, avatars, muted chats, search flag, sponsored clicks); what remains here is push-to-talk, the e2e scenario, and small fixes.
Type
Platforms
Proof
Scenario: e2e/scenarios/telegram-forum-landing
Lab run: pending — the lab records it on the base and on this branch once CI spins up.
Compatibility
No protocol change: the diff touches no
crates/protocolfile. The local store keeps its schema (10); the expiry early-return only skips a no-op write.Risk and rollback
Push-to-talk rides the existing
PUSH_TO_TALKsetting and changes the mic button only when it is on. Everything else is a test, a scenario, or a no-op-write guard. Rollback: revert the branch.Release note
Holding the mic records with push-to-talk on, and the expiry pass idles when nothing runs out.