feat(workbench): 工程列自动展开与 Preview 标签(#1964 #1966) - #1979
Merged
Conversation
Co-authored-by: Codex <codex@vectorcontrol.tech>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Codex <codex@vectorcontrol.tech>
DeliciousBuding
force-pushed
the
feat/engineering-column-surface
branch
from
August 25, 2026 07:31
344b3c1 to
229e8ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
UIUX 基准(
docs/reference/ux-benchmark-2026-08.md)F4/F9 两个 P1 项。同一文件域(workbench 工程列/auxPanel/布局偏好),按域分组集成例外合为一个 PR。Closes #1964
Closes #1966
#1964 active run 自动展开工程列(UX F4)
useEngineeringColumnAutoOpen:engineeringColumnActivitySignal聚合 isAgentRunning 与 runtime evidence(diff/artifacts/previews loading、最新产物);信号出现且视口允许时自动展开工程列。workbenchPreferences.ts新增按会话的{collapsed, autoOpenSuppressed}(localStorage,坏数据 fail-closed,不跨会话泄漏)。用户在运行中手动收回 → 本会话抑制后续自动弹出;纯聊天收回不产生抑制;切换会话恢复各自选择。useEngineeringColumnAutoOpen.test.tsx+workbenchPreferences.test.ts(含持久化、抑制、会话隔离、窄视口)。terminal dock 口径:terminal dock 无折叠状态(
shouldRenderTerminalDock仅按 isChatPage + localTerminal 能力门控,Desktop 聊天页恒显,#1182/#1825),因此自动展开合同落在工程列(inspector 列);dock 不存在"默认不展开"的缺口。#1966 工程列 Preview 标签(UX F9)
preview标签(会话/文件/变更/预览/提交,resolveAvailableAuxTabs新维度previewAvailable)。docs/architecture/04-frontend-data-flow.md§工程列焦点合同):Preview 不修改 RightInspector 详情标签;仅显式"在详情中查看 / View details"经WORKBENCH_INSPECTOR_QUICK_OPEN_EVENT请求 inspector 切换 Browser/Files。engineering.*中英键位一致;原硬编码中文标签全部收口 i18n。ChatEngineeringColumn.test.tsx(聚焦/不打架/键盘可达/详情桥接/诚实空态)、resolveAuxTabs.test.ts、AuxPanel.test.tsx、WorkbenchFrameParts.test.tsx(Web Hub-only 挂载)、inspector.test.tsx断言更新。验证
--no-file-parallelism --maxWorkers=1):workbench 全量 142 files / 1399 tests 绿;shared 全量 152 files / 2636 tests 绿。pnpm --filter @agenthub/workbench typecheck、@agenthub/shared typecheck绿。python scripts/verify/verify-i18n-callsites.pyPASS;python scripts/verify/verify-doc-ssot.pyok(04-frontend-data-flow.md 新合同段已压缩至 150 行预算内);openapi.yaml parse ok。隐私
diff 已扫描:无内部主机名、真实服务器路径、密钥。