Repository navigation
docs(todo): record the declaration-time constraint on backend-policy injection - #422
Merged
Merged
Conversation
…injection The backend-agnostic-application entry proposes injecting Delta specifics from the composition root. That shape cannot cover the api layer: DeltaTable validates properties at declaration time, and declarations are constructed at import in user modules, before any engine or backend exists. Recording it now so the future refactor is not planned around an impossible shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds one paragraph to the backend-agnostic-application entry in
docs/todo/todo.md, recording a constraint on the proposed injection refactor.Why
The entry's direction — application holds only mechanism, Delta specifics injected from the composition root — has a hard limit that is easy to miss when planning it:
DeltaTable.__init__validates properties at declaration time, and declarations are constructed at import in user modules, long before an engine or backend is chosen. No composition root exists at that moment, so full injection cannot serve the api layer. Either the backend policy stays statically importable below api (as now), or declaration-time property validation is given up — which would run against the admission-totality direction.No code changes. This closes finding 3 of the properties/features/scopes review (findings 2, 4, and 5 landed in #411 and #421; finding 1 remains).
🤖 Generated with Claude Code