Repository navigation
issues: close three data-loss records whose code is gone - #1183
Merged
Merged
Conversation
Each describes a mechanism the tree no longer has; none is fixed by re-measuring, and none applies to what replaced it. - a-64-mib-write-to-the-in-memory-data-volume-runs-its-file-server-out-of-memory: a boot with no DATA formatted the DATA format onto `Ram` (`RAM_BLOCKS`, 1 GiB) and wrote it through the block cache. 4f2efdb, in #1152 (e11b6a7), replaced that with `MemoryVolume`, whose file bytes are the kernel's paged objects alone (`system/fileserver/src/memory.rs`), so the server holds a file's names and no copy of its bytes; `Ram` is a host test device. The cache's dirty side the record suspected is bounded too (`DIRTY_LIMIT`, `system/fileserver/src/cache.rs`). - fat-unlink-reallocate-leaks-a-cluster-under-load: seen twice when the kernel drove the log volume through `toyos-fat32` over its block layer, whose `BudgetExpired` was the suspected split; 13ed7b4 removed the kernel's FAT and that layer, and the test was deleted in 3aad43b. What remains is `toyos-fat32` in the LOG file server, whose unlink and allocation `lib/fat32/tests/refused_writes.rs` drives through refusals and stops at every write under `toyos-fat32-check`. - console-line-atomicity-loses-five-of-a-thousand-lines-on-ci: lines a console holder wrote through the kernel's per-holder `ConsoleLine`; the test was deleted in 4505f87, and a788d31 made the console UART a userland driver logkeeper feeds and deleted `ConsoleLine`. Line loss on today's console path is issues/the-console-loses-what-its-carrier-had-not-delivered.md's. No file outside issues/ cites any of the three slugs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
Review r1 of #1183 at f5bba85Assessment. This PR only deletes records. I checked each closure against the commit it cites, and in every case the mechanism the record describes is gone from
RequiredNone. Suggestions
LAND |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes three open
severity: [data-loss]records whose code no longer exists. Record-only: no source changes.a-64-mib-write-to-the-in-memory-data-volume-runs-its-file-server-out-of-memoryRamblock device written through the block cache, when no DATA partition was presentMemoryVolume, whose bytes live only in the kernel's paged objects.Ramis a host test device.fat-unlink-reallocate-leaks-a-cluster-under-loadtoyos-fat32over its block layer (BudgetExpired)console-line-atomicity-loses-five-of-a-thousand-lines-on-ciConsoleLine)The commit message gives the reasoning for each. What remains of each subject is covered elsewhere:
toyos-fat32's unlink and allocation are exercised under refusals and stops bylib/fat32/tests/refused_writes.rs.issues/the-console-loses-what-its-carrier-had-not-delivered.md.Checks
git grepfor each slug outsideissues/: no hits.Fixes for the records that still apply are in a separate PR.
🤖 Generated with Claude Code