Fast black screen shutdown and remove LCD splash - #246
Merged
Conversation
rreichenbach
approved these changes
Aug 29, 2026
rreichenbach
left a comment
Collaborator
There was a problem hiding this comment.
I think I kindof preferred the screen transitions (restart sound engine, shutdown) without the black screen, but this if fine too. And yeah, good to get rid of the old splash.
Collaborator
Author
|
That’s fair—maybe a better approach would be to put up a standard “Please
wait…” modal rather than blacking out.
…On Sat, Aug 29, 2026 at 4:05 PM Randall Reichenbach < ***@***.***> wrote:
***@***.**** approved this pull request.
I think I kindof preferred the screen transitions (restart sound engine,
shutdown) without the black screen, but this if fine too. And yeah, good to
get rid of the old splash.
—
Reply to this email directly, view it on GitHub
<#246?email_source=notifications&email_token=AAG3KLGHKRMXRJGV7VD2A635MMZRBA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBVHEYDMOJXGMYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-5059069730>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG3KLHXZ7FT5TWOXPWLKY35MMZRBAVCNFSNUABFKJSXA33TNF2G64TZHMZDIMBYGAYDAMRUHNEXG43VMU5TKMRYHA2DKNZRHEYKC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AAG3KLH3OP2B6LJA4VYA3QD5MMZRBA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBVHEYDMOJXGMYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/AAG3KLDGZAXWSCUQ23O5VQT5MMZRBA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBVHEYDMOJXGMYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lcd-splashtakes care of it for ushas_system_splash(always True now)dismissablearg, True by default, to message dialogs