Conversation
Drop graph-repair edge_ids sync phases; pin jvspatial==0.0.19.
…turns _after_loop gated only on interaction.response while streaming latches emitted first, so model_unavailable compose could run twice. Unify delivery detection via _turn_delivered and skip commit_pending_adhoc when the settled text is already on the interaction. Co-authored-by: Cursor <cursoragent@cursor.com>
Hard-coded 200k for claude-sonnet-4-5 broke when LiteLLM bumped the model table to 1M; assert against litellm_capabilities() instead. Co-authored-by: Cursor <cursoragent@cursor.com>
_after_loop already used _turn_delivered; _egress still checked has_emitted() only, so a turn with interaction.response set but no latch (model_error salvage path) queued a second ReplyAction publish. Also latch emitted when commit_pending_adhoc skips an already-settled replay. Co-authored-by: Cursor <cursoragent@cursor.com>
MagicMock interactions expose a truthy non-string response attribute; _turn_delivered must check isinstance(str) before skipping egress. Co-authored-by: Cursor <cursoragent@cursor.com>
…hunk Stops a second independent user publish from twinning assistant bubbles downstream; active stream may still finish. Covered by emitted-latch tests. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_after_loop/_egresson_turn_delivered()so streaminghas_emitted()andinteraction.responsecannot both trigger a second compose on model_error turns.commit_pending_adhocto skip replay when settled text is already oninteraction.responseand latchmark_emitted.context_windowfromlitellm_capabilities()instead of hard-coded 200k.Test plan
pytest tests/action/orchestrator/test_model_error_intro_single_egress.py tests/action/orchestrator/test_model_failure.pypytest tests/action/response/test_emitted_latch.pypytest tests/action/model/test_litellm_action.py::test_capabilities_and_pricing_come_from_upstream_metadatapytestvia pre-push hook