Repository navigation
Fix executable bit on Solo theme image assets - #553
Merged
Merged
Conversation
default-skin.png, default-skin.svg, and preloader.gif in packages/solo are committed with mode 100755 (executable). They are static binary image assets and should not be executable. On self-hosted Ghost installs this trips the `ghost doctor` / `ghost update` file-permission check, which expects 644/664. This sets their mode to 100644; content is unchanged (blob SHAs are identical). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 3
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches
Comment |
Member
|
Thanks for catching this and sending the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/solo/assets/images/default-skin.png,default-skin.svg, andpreloader.gifare committed with mode100755(executable bit set). These are static binary image assets and shouldn't be executable.This is a permission-only change — the file content is untouched (blob SHAs are identical), only the mode changes from
100755→100644.Why this matters
On self-hosted Ghost installs, the executable bit causes the
ghost doctor/ghost updatefile-permission check to flag these files (it expects644/664):Resetting the mode to
100644clears the warning, matching every other asset in the theme.Notes
packages/solois affected; I didn't touch other themes, though it may be worth checking whether the same exec-bit slipped into other packages.