Skip to content

feat: Implement CSV scanning, batch slicing into typed column vect (columnar-sql-engine-storage) - #1

Merged
Trysac merged 1 commit into
mainfrom
fabrica/columnar-sql-engine-storage
Nov 8, 2026
Merged

Trysac merged 1 commit into
mainfrom
fabrica/columnar-sql-engine-storage

Conversation

@Trysac

@Trysac Trysac commented Nov 8, 2026

Copy link
Copy Markdown
Owner

Generated by fabrica for queue item columnar-sql-engine-storage (utility line). Human review required before merge.

Acceptance criteria

  • IF a CSV source exceeds MaxScanBytes of 104857600 bytes THEN RegisterCSV returns *EngineError with code 'limit_exceeded'
  • WHEN a table of 2500 rows is scanned THEN the scan emits batches of 1024, 1024 and 452 rows

Gates

All local gates passed (fabrica.json check); acceptance literals are used by the tests; an independent audit ran. Fix rounds: 0.

Measured cost

6 API calls, $0.5031 (tokens in docs/PROJECT.md).

Copilot AI balanced review requested due to automatic review settings November 8, 2026 05:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@Trysac
Trysac merged commit 3048604 into main Nov 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants