Skip to content

feat: Implement vectorized execution operators, three-valued NULL (columnar-sql-engine-vector-exec) - #6

Merged
Trysac merged 2 commits into
mainfrom
fabrica/columnar-sql-engine-vector-exec
Nov 8, 2026
Merged

Trysac merged 2 commits into
mainfrom
fabrica/columnar-sql-engine-vector-exec

Conversation

@Trysac

@Trysac Trysac commented Nov 8, 2026

Copy link
Copy Markdown
Owner

Generated by fabrica for queue item columnar-sql-engine-vector-exec (utility line). Human review required before merge.

Acceptance criteria

  • WHEN table t(id INT64, g VARCHAR, v FLOAT64) holds (1,'a',1.5), (2,'a',2.5), (3,'b',NULL) and Query runs 'SELECT g, SUM(v), COUNT(v), COUNT(*) FROM t GROUP BY g ORDER BY g' THEN rows are ('a', 4.0, 2, 2) and ('b', NULL, 0, 1)
  • WHEN l(id) holds 1 and NULL and r(id) holds 1 and NULL THEN 'SELECT COUNT(*) FROM l JOIN r ON l.id = r.id' returns 1 and the LEFT JOIN form returns 2
  • WHEN Query runs 'SELECT NULL AND FALSE, NULL OR TRUE, NULL = NULL' THEN the row is (false, true, NULL)
  • WHEN Query runs 'SELECT v FROM t ORDER BY v NULLS FIRST' THEN the first value is NULL, and with NULLS LAST the last value is NULL

Gates

All local gates passed (fabrica.json check); acceptance literals are used by the tests; an independent audit ran. Fix rounds: 5.

Measured cost

10 API calls, $1.1718 (tokens in docs/PROJECT.md).

Copilot AI balanced review requested due to automatic review settings November 8, 2026 06:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@Trysac
Trysac merged commit f2ca70a into main Nov 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants