Skip to content

fix(latex): leftover tcbmakedocSubKey and documentation refs #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaoZeke merged 1 commit into from
Sep 15, 2026
Merged

fix(latex): leftover tcbmakedocSubKey and documentation refs #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion src/sentence/unicode.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1590,6 +1590,21 @@ pub(crate) fn leftover_keyval_cs_name(tail: &str) -> Option<&'static str> {
"tcbwritetemp",
"tcbrecord",
"tcbbreak",
"refPathOperation",
"docAuxEnvironment",
"docAuxCommand",
"docKeyChoices",
"docAuxKey",
"docCounter",
"docLength",
"docColor",
"docValue",
"refAuxcs",
"refCom",
"refEnv",
"refKey",
"refAux",
"refPkg",
"tcbdocmarginnote",
"tcbdocupdated",
"tcbdocnote",
Expand Down Expand Up @@ -1654,7 +1669,22 @@ pub(crate) fn leftover_keyval_cs_name(tail: &str) -> Option<&'static str> {
let Some(after) = tail.strip_prefix(name) else {
continue;
};
let reject_star = name != "tcbline";
let reject_star = !matches!(
name,
"tcbline"
| "refCom"
| "refEnv"
| "refKey"
| "refPathOperation"
| "docAuxCommand"
| "docAuxEnvironment"
| "docAuxKey"
| "docCounter"
| "docLength"
| "docColor"
| "docValue"
| "docKeyChoices"
);
if after.starts_with(|c: char| c.is_ascii_alphabetic() || (reject_star && c == '*')) {
return None;
}
Expand Down Expand Up @@ -1733,6 +1763,7 @@ fn leftover_keyval_kind(name: &str) -> VerbKind {
| "tcboxfit"
| "tcbox"
| "tcbhyperref"
| "docAuxKey"
| "tcbhypernode"
| "tcbverbatimwrite"
| "tcbrecord"
Expand Down
23 changes: 23 additions & 0 deletions tests/latex_leftover_cmds.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,25 @@ fn leftover_constructors_do_not_join() {
leftover_cmd_stays_atomic(r"\tcbdocdescDefault{foo}");
leftover_cmd_stays_atomic(r"\tcbdocdescDefaultInitEmpty{foo}");
leftover_cmd_stays_atomic(r"\tcbdocdescDefaultInit{foo}{bar}");
leftover_cmd_stays_atomic(r"\tcbmakedocSubKey{docFooKey}{foo}");
leftover_cmd_stays_atomic(r"\tcbmakedocSubKeys[colback=red]{docFooKeys}{foo}");
leftover_cmd_stays_atomic(r"\refCom{tcbset}");
leftover_cmd_stays_atomic(r"\refCom*{tcbset}");
leftover_cmd_stays_atomic(r"\refEnv{docCommand}");
leftover_cmd_stays_atomic(r"\refKey{/tcb/colback}");
leftover_cmd_stays_atomic(r"\refPathOperation{lineto}");
leftover_cmd_stays_atomic(r"\refAux{foo}");
leftover_cmd_stays_atomic(r"\refAuxcs{foo}");
leftover_cmd_stays_atomic(r"\refPkg{tcolorbox}");
leftover_cmd_stays_atomic(r"\docAuxCommand{foo}");
leftover_cmd_stays_atomic(r"\docAuxEnvironment{foo}");
leftover_cmd_stays_atomic(r"\docAuxKey{colback}");
leftover_cmd_stays_atomic(r"\docAuxKey[tcb]{colback}");
leftover_cmd_stays_atomic(r"\docKeyChoices{red,blue}");
leftover_cmd_stays_atomic(r"\docCounter{tcbcounter}");
leftover_cmd_stays_atomic(r"\docLength{linewidth}");
leftover_cmd_stays_atomic(r"\docColor{red}");
leftover_cmd_stays_atomic(r"\docValue{none}");
leftover_cmd_stays_atomic(r"\tcbindex");
leftover_cmd_stays_atomic(r"\tcbEXTERNALIZE");
leftover_cmd_stays_atomic(r"\tcbifexternal{odd. More}{even. More}");
Expand All @@ -368,6 +387,10 @@ fn leftover_constructors_do_not_join() {
extras_skip_no_brace("pyif");
extras_skip_no_brace("lstdefineformat");
extras_skip_no_brace("newtcolorbox");
extras_skip_no_brace("tcbmakedocSubKey");
extras_skip_no_brace("tcbmakedocSubKeys");
extras_skip_no_brace("refCom");
extras_skip_no_brace("docAuxCommand");
extras_skip_no_brace("tcbset");
extras_skip_no_brace("tcbuselibrary");
extras_skip_no_brace("setpythontexprettyprinter");
Expand Down
Loading