Skip to content

Speed up Simulation by moving the declaration of the simple_func dict out of _execute - #493

Merged
fdxmw merged 1 commit into
UCSBarchlab:developmentfrom
fdxmw:sim
Jul 14, 2026
Merged

fdxmw merged 1 commit into
UCSBarchlab:developmentfrom
fdxmw:sim

Conversation

@fdxmw

@fdxmw fdxmw commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Before this change, pyrtlnet with pyrtl.Simulation runs in 2.2 seconds on my desktop, and after this change it runs in 1.3 seconds.

(pyrtlnet runs with pyrtl.FastSimulation by default, which runs in 0.1 seconds).

…ct out of `_execute`.

Before this change, pyrtlnet with `pyrtl.Simulation` runs in 2.2 seconds on my
desktop, and after this change it runs in 1.3 seconds.

(pyrtlnet runs with `pyrtl.FastSimulation` by default, which runs in 0.1 seconds).
@fdxmw
fdxmw merged commit d3eee38 into UCSBarchlab:development Jul 14, 2026
2 checks passed
@fdxmw
fdxmw deleted the sim branch July 14, 2026 17:59
@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.2%. Comparing base (0dbbbc6) to head (2b5fc5f).
⚠️ Report is 30 commits behind head on development.

Files with missing lines Patch % Lines
pyrtl/simulation.py 92.9% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           development    #493     +/-   ##
=============================================
- Coverage         92.2%   92.2%   -0.0%     
=============================================
  Files               30      30             
  Lines             7450    7452      +2     
=============================================
+ Hits              6865    6866      +1     
- Misses             585     586      +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant