Include user first and last names and correct email responses

[krowvin]

User responses now include first-name and last-name when available. The /users list also returns the user's email address instead of incorrectly copying the principal ID into email.

This applies to GET /users, GET /users/{user-name}, and GET /user/profile. Existing identifiers and roles are preserved. Missing contact values are omitted, and older JSON without names remains readable.

JSON comparison

One user entry from GET /users, with the paging wrapper omitted. All identity and contact values below are synthetic.

Before:

{
  "user-name": "TEST_USER",
  "principal": "test-contact-principal",
  "email": "test-contact-principal",
  "roles": { "HQ": ["CWMS Users"] }
}

After:

{
  "user-name": "TEST_USER",
  "principal": "test-contact-principal",
  "first-name": "Alex",
  "last-name": "Example",
  "email": "alex.example@example.com",
  "roles": { "HQ": ["CWMS Users"] }
}

Individual-user and profile responses already returned the stored email correctly; they gain the two name fields. The new names come from the existing user profile, without interpreting the username or principal as a person's name.

Validation

• gradlew build on Java 11 passed, including the Java tests, live OpenAPI export, documentation, and generated TypeScript client build. The CDA unit suite reported 774 tests, zero failures, and 40 skipped.

• JSON tests cover contact-field round trips, omitted missing values, and reading the old response format.

• gradlew :cwms-data-api:integrationTests --tests '*UserManagementTestIT' on Java 11 passed all 15 tests against a locally started CDA instance. Coverage includes populated and missing contact fields in the list, individual-user, and profile responses, lookup by username and principal, existing pagination, and authorization checks.

• AI tools used