Omit API key secrets from GET responses and clarify one-time retrieval - #1941
Open
krowvin wants to merge 2 commits into
Open
Omit API key secrets from GET responses and clarify one-time retrieval#1941krowvin wants to merge 2 commits into
krowvin wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET
/auth/keysand/auth/keys/{key-name}currently return"api-key": null, which suggests the secret should be available. Return only key metadata and removeapi-keyfrom both HTTP 200 response schemas. POST continues to return the generated secret in its HTTP 201 response.Companion UI guidance is in #1923, with bold warnings in the creation, save, help, and rotation instructions.
Validation: Java 11 service tests passed (745 passed, 40 skipped), including the three new serialization/OpenAPI regression tests; Checkstyle and WAR assembly completed. Rendered Swagger panels verified both bold GET notices and metadata-only examples. The full Gradle build reached the Docker-backed OpenAPI export, which failed because no Docker environment is available; Oracle integration and downstream generated-client validation remain unverified.
Swagger screenshots were captured outside the source tree. Attachment was blocked: the browser file chooser timed out, and native computer use stopped because it could not verify the Chrome URL.
AI tools used